Palacios Public Git Repository

To checkout Palacios execute

  git clone http://v3vee.org/palacios/palacios.web/palacios.git
This will give you the master branch. You probably want the devel branch or one of the release branches. To switch to the devel branch, simply execute
  cd palacios
  git checkout --track -b devel origin/devel
The other branches are similar.


Fixed a = versus == thing
Peter Dinda [Fri, 17 Oct 2008 16:58:26 +0000 (11:58 -0500)]
palacios/src/palacios/vmm_shadow_paging.c

index cc4ced5..6c8e1fe 100644 (file)
@@ -439,6 +439,7 @@ static int handle_shadow_pagefault32(struct guest_info * info, addr_t fault_addr
       if (guest_pde->large_page == 0) {
        shadow_pde->writable = guest_pde->writable;
       } else {
+       // ??  What if guest pde is dirty a this point?
        ((pde32_4MB_t *)guest_pde)->dirty = 0;
        shadow_pde->writable = 0;
       }
@@ -615,7 +616,7 @@ static int handle_shadow_pte32_fault(struct guest_info * info,
          state->cached_cr3 = 0;
        }
 
-      } else if ((guest_pte->dirty = 0) && (error_code.write == 0)) {
+      } else if ((guest_pte->dirty == 0) && (error_code.write == 0)) {  // was =
        shadow_pte->writable = 0;
       }