From: Peter Dinda <pdinda@northwestern.edu>
Date: Fri, 17 Oct 2008 16:58:26 +0000 (-0500)
Subject: Fixed a = versus == thing
X-Git-Tag: 1.0^2~42
X-Git-Url: http://v3vee.org/palacios/gitweb/gitweb.cgi?p=palacios.git;a=commitdiff_plain;h=cb92a05b8a83e87b7496eb6d14cd4c593c0b653b

Fixed a = versus == thing
---

diff --git a/palacios/src/palacios/vmm_shadow_paging.c b/palacios/src/palacios/vmm_shadow_paging.c
index cc4ced5..6c8e1fe 100644
--- a/palacios/src/palacios/vmm_shadow_paging.c
+++ b/palacios/src/palacios/vmm_shadow_paging.c
@@ -439,6 +439,7 @@ static int handle_shadow_pagefault32(struct guest_info * info, addr_t fault_addr
       if (guest_pde->large_page == 0) {
 	shadow_pde->writable = guest_pde->writable;
       } else {
+	// ??  What if guest pde is dirty a this point?
 	((pde32_4MB_t *)guest_pde)->dirty = 0;
 	shadow_pde->writable = 0;
       }
@@ -615,7 +616,7 @@ static int handle_shadow_pte32_fault(struct guest_info * info,
 	  state->cached_cr3 = 0;
 	}
 
-      } else if ((guest_pte->dirty = 0) && (error_code.write == 0)) {
+      } else if ((guest_pte->dirty == 0) && (error_code.write == 0)) {  // was =
 	shadow_pte->writable = 0;
       }