Cleanup and sanity-checking of endianness, dead code, unchecked returns (Coverity...

[palacios.git] / palacios / src / palacios / mmu / vmm_shdw_pg_tlb_32pae.h

diff --git a/palacios/src/palacios/mmu/vmm_shdw_pg_tlb_32pae.h b/palacios/src/palacios/mmu/vmm_shdw_pg_tlb_32pae.h
index d5e75a1..492d5a1 100644 (file)
--- a/palacios/src/palacios/mmu/vmm_shdw_pg_tlb_32pae.h
+++ b/palacios/src/palacios/mmu/vmm_shdw_pg_tlb_32pae.h
@@ -73,7 +73,7 @@ static inline int handle_shadow_pagefault_32pae(struct guest_info * info, addr_t
     PrintDebug(info->vm_info, info, "32 bit PAE shadow paging page fault handler: %p\n", (void*)fault_addr);
     PrintDebug(info->vm_info, info, "Handling PDP fault\n");
     
-    if (v3_gpa_to_hva(info, guest_cr3, (addr_t*)guest_pdp) ==  -1) {
+    if (v3_gpa_to_hva(info, guest_cr3, (addr_t*)&guest_pdp) ==  -1) {
         PrintError(info->vm_info, info, "Invalid Guest PDPE Address: 0x%p\n", (void *)guest_cr3);
         return -1;
         
@@ -727,9 +727,6 @@ static int invalidation_cb32pae_64(struct guest_info * info, page_type_t type,
                        if (pdpe->vmm_info == V3_LARGE_PG) {
                                PrintError(info->vm_info, info, "1 Gigabyte pages not supported\n");
                                return -1;
-
-                               pdpe->present = 0;
-                               return 1;
                        }
 
                        return 0;