Cleanup and sanity-checking of use of strncpy/strcpy (Coverity static analysis)

[palacios.git] / palacios / src / extensions / ext_inspector.c

diff --git a/palacios/src/extensions/ext_inspector.c b/palacios/src/extensions/ext_inspector.c
index 4c58775..db12f05 100644 (file)
--- a/palacios/src/extensions/ext_inspector.c
+++ b/palacios/src/extensions/ext_inspector.c
@@ -40,13 +40,14 @@ static int init_inspector(struct v3_vm_info * vm, v3_cfg_tree_t * cfg, void ** p
     struct v3_inspector_state * state = V3_Malloc(sizeof(struct v3_inspector_state));
 
     if (!state) {
-       PrintError("Cannot allocate state in inspector\n");
+       PrintError(vm, VCORE_NONE, "Cannot allocate state in inspector\n");
        return -1;
     }
 
     memset(state, 0, sizeof(struct v3_inspector_state));
 
     strncpy(state->state_tree.name, "vm->name", 50);
+    state->state_tree.name[49] = 0;
     state->state_tree.subtree = 1;
 
     *priv_data = state;
@@ -55,7 +56,7 @@ static int init_inspector(struct v3_vm_info * vm, v3_cfg_tree_t * cfg, void ** p
 }
 
 
-static int init_inspector_core(struct guest_info * core, void * priv_data) {
+static int init_inspector_core(struct guest_info * core, void * priv_data, void ** core_data) {
     struct v3_inspector_state * vm_state = priv_data;
     char core_name[50];
 
@@ -103,8 +104,9 @@ static int init_inspector_core(struct guest_info * core, void * priv_data) {
 
 static struct v3_extension_impl inspector_impl = {
     .name = "inspector",
-    .init = init_inspector,
-    .deinit = NULL,
+    .init = NULL,
+    .vm_init = init_inspector,
+    .vm_deinit = NULL,
     .core_init = init_inspector_core,
     .core_deinit = NULL,
     .on_entry = NULL,