VGA bug fix

[palacios.git] / palacios / src / devices / vga_regs.h

diff --git a/palacios/src/devices/vga_regs.h b/palacios/src/devices/vga_regs.h
index 08b65f2..f29a812 100644 (file)
--- a/palacios/src/devices/vga_regs.h
+++ b/palacios/src/devices/vga_regs.h
@@ -199,6 +199,7 @@ struct vga_mem_mode_reg {
            uint8_t extended_memory:1; // 1=>256K RAM, 0=>64K
            uint8_t odd_even:1;
                 // 0 => even addresses go to BOTH banks 0 and 2, odd 1 and 3
+               //      or flip between 0/1 for CGA compat
                 // 1 => address bank sequentially, map mask selects bank
            uint8_t chain4:1;  
                 // 0 => map mask register used to select bank
@@ -630,6 +631,8 @@ page 2-88).
            // 0 = read gets bits from selected map
            uint8_t odd_even:1;
            // 1 = odd/even addressing as in CGMA
+           // 0 = NOT odd/even
+           // notice that this is the OPPOSITE of the bit in the sequencer!
            uint8_t shift_reg_mode:1;
            // 1 = shift regs get odd bits from odd maps and even/even
            uint8_t c256:1;                 // 1 = 256 color mode
@@ -751,7 +754,7 @@ struct vga_attribute_mode_control_reg {
            uint8_t enable_line_graphics_char_code:1;
            // 1 => enable special line graphics characters
            //      and force 9th dot to be same as 8th dot of char
-           uint8_t enable_blink;
+           uint8_t enable_blink:1;
            // 1 => MSB of the attribute means blink (8 colors + blink)
            // 0 => MSB of the attribute means intensity (16 colors)
            uint8_t reserved:1;