Minor VMX NPT bug fix (printing)

[palacios.git] / palacios / src / palacios / vmm_quix86.c

diff --git a/palacios/src/palacios/vmm_quix86.c b/palacios/src/palacios/vmm_quix86.c
index ac4ce9c..befc9d1 100644 (file)
--- a/palacios/src/palacios/vmm_quix86.c
+++ b/palacios/src/palacios/vmm_quix86.c
@@ -27,6 +27,16 @@
 
 #include <quix86/quix86.h>
 
+#ifdef V3_CONFIG_TM_FUNC
+#include <extensions/trans_mem.h>
+#endif
+
+#ifdef V3_CONFIG_DEBUG_TM_FUNC
+#define PrintTMDebug(...) V3_Print(__VA_ARGS__)
+#else
+#define PrintTMDebug(...)
+#endif
+
 #ifndef V3_CONFIG_DEBUG_DECODER
 #undef PrintDebug
 #define PrintDebug(fmt, args...)
@@ -151,6 +161,13 @@ int v3_decode(struct guest_info * info, addr_t instr_ptr, struct x86_instr * ins
     memset(instr, 0, sizeof(struct x86_instr));
     memset(&qx86_inst, 0, sizeof(qx86_inst));
 
+#ifdef V3_CONFIG_TM_FUNC
+    if (v3_tm_decode_rtm_instrs(info, instr_ptr, instr) == -1) {
+        return -1;
+    }
+#endif
+
+
     v3_get_prefixes((uchar_t *)instr_ptr, &(instr->prefixes));
 
     switch(v3_get_vm_cpu_mode(info)) {
@@ -204,6 +221,14 @@ int v3_decode(struct guest_info * info, addr_t instr_ptr, struct x86_instr * ins
 
     instr->instr_length = qx86_inst.rawSize;
 
+    // 441 - dump memory for quix86 debugging
+    if ((instr->op_type = get_opcode(&qx86_inst,info)) == V3_INVALID_OP) {
+        PrintError(info->vm_info, info, "++==++ QX86 DECODE ++==++, guest RIP: %llx\n", info->rip);
+        v3_dump_mem((void *)instr_ptr, 15);
+        PrintError(info->vm_info, info, "Could not get opcode. (mnemonic=%s)\n",
+                qx86_minfo(qx86_inst.mnemonic)->name);
+        return -1;
+    }
     if ((instr->op_type = get_opcode(&qx86_inst, info)) == V3_INVALID_OP) {
         PrintError(info->vm_info, info, "Could not get opcode. (mnemonic=%s)\n",
                 qx86_minfo(qx86_inst.mnemonic)->name);
@@ -274,6 +299,10 @@ static int get_opcode(qx86_insn *inst, struct guest_info *core) {
             return V3_OP_MOV2CR;
         if(IS_CR(1))
             return V3_OP_MOVCR2;
+        // 441 - mov reg reg is also ok
+        if(inst->operands[0].ot == QX86_OPERAND_TYPE_REGISTER
+                || inst->operands[1].ot == QX86_OPERAND_TYPE_REGISTER)
+            return V3_OP_MOV;
 
         PrintError(core->vm_info, core, "Bad operand types for MOV: %d %d\n", inst->operands[0].ot,
                 inst->operands[1].ot);
@@ -395,6 +424,66 @@ static int get_opcode(qx86_insn *inst, struct guest_info *core) {
     case QX86_MNEMONIC_STOSQ:
         return V3_OP_STOS;
 
+    /* 441-tm: add in CMP, POP, JLE, CALL cases */
+    case QX86_MNEMONIC_CMP:
+        return V3_OP_CMP;
+
+    case QX86_MNEMONIC_POP:
+        return V3_OP_POP;
+
+    case QX86_MNEMONIC_JLE:
+        return V3_OP_JLE;
+
+    case QX86_MNEMONIC_CALL:
+        return V3_OP_CALL;
+
+    case QX86_MNEMONIC_TEST:
+        return V3_OP_TEST;
+
+    case QX86_MNEMONIC_PUSH:
+        return V3_OP_PUSH;
+
+    case QX86_MNEMONIC_JAE:
+        return V3_OP_JAE;
+
+    case QX86_MNEMONIC_JMP:
+        return V3_OP_JMP;
+
+    case QX86_MNEMONIC_JNZ:
+        return V3_OP_JNZ;
+
+    case QX86_MNEMONIC_JZ:
+        return V3_OP_JZ;
+
+    case QX86_MNEMONIC_RET:
+        return V3_OP_RET;
+
+    case QX86_MNEMONIC_IMUL:
+        return V3_OP_IMUL;
+
+    case QX86_MNEMONIC_LEA:
+        return V3_OP_LEA;
+
+    case QX86_MNEMONIC_JL:
+        return V3_OP_JL;
+
+    case QX86_MNEMONIC_CMOVZ:
+        return V3_OP_CMOVZ;
+
+    case QX86_MNEMONIC_MOVSXD:
+        return V3_OP_MOVSXD;
+
+    case QX86_MNEMONIC_JNS:
+        return V3_OP_JNS;
+
+    case QX86_MNEMONIC_CMOVS:
+        return V3_OP_CMOVS;
+
+    case QX86_MNEMONIC_SHL:
+        return V3_OP_SHL;
+
+    case QX86_MNEMONIC_INT:
+        return V3_OP_INT;
 
     default:
         return V3_INVALID_OP;