}
-//irq is pirq_rc[intr_pin + pci_dev_num - 1] & 0x3
+//irq is pirq_rc[intr_pin + pci_dev_num - 1] & 0xf
+/*
+struct pirq_rc_reg {
+ uint8_t irq : 4;
+ uint8_t rsvd : 3;
+ uint8_t disabled : 1; // (1=disabled, 0=enabled)
+}
+*/
+
static int raise_pci_irq(struct pci_device * pci_dev, void * dev_data) {
struct v3_southbridge * piix3 = dev_data;
int intr_pin = pci_dev->config_header.intr_pin - 1;
int irq_index = (intr_pin + pci_dev->dev_num - 1) & 0x3;
- // PrintError("Raising PCI IRQ %d\n", piix3_cfg->pirq_rc[irq_index]);
+ //PrintError("Raising PCI IRQ %d, %p\n", piix3_cfg->pirq_rc[irq_index], piix3->vm);
- v3_raise_irq(piix3->vm, piix3_cfg->pirq_rc[irq_index]);
+ if (piix3_cfg->pirq_rc[irq_index] < 16) {
+ v3_raise_irq(piix3->vm, piix3_cfg->pirq_rc[irq_index] & 0xf);
+ } else {
+ PrintError("Tried to raise interrupt on disabled PIRQ entry (%d)\n", irq_index);
+ PrintError("\tpirq_rc values: 0=0x%x, 1=0x%x, 2=0x%x, 3=0x%x\n",
+ piix3_cfg->pirq_rc[0], piix3_cfg->pirq_rc[1],
+ piix3_cfg->pirq_rc[2], piix3_cfg->pirq_rc[3]);
+ return -1;
+ }
return 0;
}
// PrintError("Lowering PCI IRQ %d\n", piix3_cfg->pirq_rc[irq_index]);
- v3_lower_irq(piix3->vm, piix3_cfg->pirq_rc[irq_index]);
+ if (piix3_cfg->pirq_rc[irq_index] < 16) {
+ v3_lower_irq(piix3->vm, piix3_cfg->pirq_rc[irq_index] & 0xf);
+ } else {
+ PrintError("Tried to lower interrupt on disabled PIRQ entry (%d)\n", irq_index);
+ PrintError("\tpirq_rc values: 0=0x%x, 1=0x%x, 2=0x%x, 3=0x%x\n",
+ piix3_cfg->pirq_rc[0], piix3_cfg->pirq_rc[1],
+ piix3_cfg->pirq_rc[2], piix3_cfg->pirq_rc[3]);
+ return -1;
+ }
return 0;
}
-static int piix_free(struct vm_device * dev) {
+static int piix_free(struct v3_southbridge * piix3) {
+
+ // unregister pci
+
+ V3_Free(piix3);
return 0;
}
static struct v3_device_ops dev_ops = {
- .free = piix_free,
+ .free = (int (*)(void *))piix_free,
};
piix3->pci_bus = pci;
piix3->type = V3_SB_PIIX3;
+ piix3->vm = vm;
- dev = v3_allocate_device(dev_id, &dev_ops, piix3);
+ dev = v3_add_device(vm, dev_id, &dev_ops, piix3);
- if (v3_attach_device(vm, dev) == -1) {
+ if (dev == NULL) {
PrintError("Could not attach device %s\n", dev_id);
+ V3_Free(piix3);
return -1;
}
PrintDebug("Created PIIX3\n");
- return setup_pci(piix3);
+ if (setup_pci(piix3) == -1) {
+ v3_remove_device(dev);
+ return -1;
+ }
+
+ return 0;
}