Palacios Public Git Repository

To checkout Palacios execute

  git clone http://v3vee.org/palacios/palacios.web/palacios.git
This will give you the master branch. You probably want the devel branch or one of the release branches. To switch to the devel branch, simply execute
  cd palacios
  git checkout --track -b devel origin/devel
The other branches are similar.


stream implementation and interface between searial device and stream
[palacios.git] / palacios / src / devices / lnx_virtio_vnet.c
index c29b006..435df48 100644 (file)
@@ -13,7 +13,7 @@
  * All rights reserved.
  *
  * Author: Jack Lange <jarusl@cs.northwestern.edu>
- *            Lei Xia <lxia@cs.northwestern.edu>
+ *             Lei Xia <lxia@cs.northwestern.edu>
  *
  * This is free software.  You are permitted to use,
  * redistribute, and modify it as specified in the file "V3VEE_LICENSE".
@@ -273,7 +273,7 @@ static int vnet_pkt_input_cb(struct v3_vm_info * vm,  struct v3_vnet_pkt vnet_pk
            q->cur_avail_idx++;
        } else {
            vnet_state->pkt_drop ++;
-           v3_vnet_disable_bridge();
+           //v3_vnet_disable_bridge();
        }
     }
 
@@ -291,7 +291,7 @@ static int vnet_pkt_input_cb(struct v3_vm_info * vm,  struct v3_vnet_pkt vnet_pk
 
        
 #ifdef CONFIG_VNET_PROFILE
-    if (vnet_state->pkt_recv % 200000 == 0)
+    if (vnet_state->pkt_recv % 20000 == 0)
        PrintError("Vnet Bridge: sent: %ld, rxed: %ld, dropped: %ld, total exit: %ld, tx exit: %ld, rx exit: %ld\n",
                        vnet_state->pkt_sent,
                        vnet_state->pkt_recv,
@@ -308,22 +308,19 @@ exit:
     return ret_val;
 }
 
-static void vnet_pkt_input_xcall(void *data){
-    struct v3_vnet_bridge_input_args *args = (struct v3_vnet_bridge_input_args *)data;
+static int vnet_pkt_input_xcall(void *data){
+    struct v3_vnet_bridge_xcall_args *args = (struct v3_vnet_bridge_xcall_args *)data;
        
-    vnet_pkt_input_cb(args->vm, args->vnet_pkts, args->pkt_num, args->private_data);
+    return vnet_pkt_input_cb(args->vm, args->vnet_pkts, args->pkt_num, args->private_data);
 }
 
 static int handle_pkt_kick(struct guest_info *core, struct virtio_vnet_state * vnet_state) 
 {
     struct virtio_queue * q = &(vnet_state->queue[XMIT_QUEUE]);
-    unsigned long flags = 0;
     int recvd = 0;
        
-    flags = v3_lock_irqsave(vnet_state->lock);
-
     if (q->ring_avail_addr == 0) {
-       goto exit;
+       return -1;
     }
 
     while (q->cur_avail_idx != q->avail->index) {
@@ -340,10 +337,17 @@ static int handle_pkt_kick(struct guest_info *core, struct virtio_vnet_state * v
            return -1;
        }
 
-       PrintDebug("VNET Bridge: TX: on cpu %d pkt size: %d, dst link: %d\n", cpu, virtio_pkt->pkt_size, virtio_pkt->link_id);
-       
-       v3_vnet_rx(virtio_pkt->pkt, virtio_pkt->pkt_size, virtio_pkt->link_id, LINK_EDGE);
+       //PrintDebug("VNET Bridge: TX: on cpu %d pkt size: %d, dst link: %d\n", cpu, virtio_pkt->pkt_size, virtio_pkt->link_id);
+
+       struct v3_vnet_pkt pkt;
+       pkt.size = virtio_pkt->pkt_size;
+       pkt.src_type = LINK_EDGE;
+       pkt.src_id = 0;
+       memcpy(pkt.header, virtio_pkt->pkt, ETHERNET_HEADER_LEN);
+       pkt.data = virtio_pkt->pkt;
 
+       v3_vnet_send_pkt(&pkt, NULL);
+       
        q->used->ring[q->used->index % q->queue_size].id = q->avail->ring[q->cur_avail_idx % q->queue_size];
        q->used->ring[q->used->index % q->queue_size].length = pkt_desc->length; // What do we set this to????
        q->used->index++;
@@ -355,30 +359,18 @@ static int handle_pkt_kick(struct guest_info *core, struct virtio_vnet_state * v
     }
 
     if(recvd == 0){
-       goto exit;
-    }
-
-    //PrintError("In polling get %d\n", recvd);
-       
-    //if on the dom0 core, interrupt the domU core to poll pkts
-    //otherwise, call the polling directly
-    int cpu = V3_Get_CPU();
-    if(vnet_state->vm->cores[0].cpu_id == cpu){
-       cpu = (cpu == 0)?1:0;
-       v3_interrupt_cpu(vnet_state->vm, cpu, V3_VNET_POLLING_VECTOR);
-    }else{
-       v3_vnet_polling();
+       return 0;
     }
 
-    if((vnet_state->pkt_sent % (QUEUE_SIZE/20)) == 0) { //optimized for guest's, batch the interrupts
-           if (!(q->avail->flags & VIRTIO_NO_IRQ_FLAG)) {
-               v3_pci_raise_irq(vnet_state->pci_bus, 0, vnet_state->pci_dev);
-               vnet_state->virtio_cfg.pci_isr = 0x1;
-           }
+    if (!(q->avail->flags & VIRTIO_NO_IRQ_FLAG)) {
+           v3_pci_raise_irq(vnet_state->pci_bus, 0, vnet_state->pci_dev);
+           vnet_state->virtio_cfg.pci_isr = 0x1;
     }
 
+    //PrintError("Virtio VNET: polling %d pkts\n", recvd);
+       
 #ifdef CONFIG_VNET_PROFILE
-    if (vnet_state->pkt_sent % 200000 == 0)
+    if (vnet_state->pkt_sent % 20000 == 0)
        PrintError("Vnet Bridge: sent: %ld, rxed: %ld, dropped: %ld, total exit: %ld, tx exit: %ld, rx exit: %ld\n",
                        vnet_state->pkt_sent,
                        vnet_state->pkt_recv,
@@ -388,21 +380,20 @@ static int handle_pkt_kick(struct guest_info *core, struct virtio_vnet_state * v
                        vnet_state->rx_exit);
 #endif
 
-exit:
-    v3_unlock_irqrestore(vnet_state->lock,flags);
-
     return 0;
 }
 
-static int polling_pkt_from_guest(struct v3_vm_info * vm, void *private_data){
+static void vnet_virtio_poll(struct v3_vm_info * vm, void *private_data){
     struct virtio_vnet_state * vnet_state = (struct virtio_vnet_state *)private_data;
-       
-    return handle_pkt_kick(&(vm->cores[0]), vnet_state);
+
+    if(vm == vnet_state->vm){  
+       handle_pkt_kick(&(vm->cores[0]), vnet_state);
+    }
 }
 
 static int handle_rx_kick(struct guest_info *core, struct virtio_vnet_state * vnet_state) 
 {
-    v3_vnet_enable_bridge();
+    //v3_vnet_enable_bridge();
        
     return 0;
 }
@@ -413,10 +404,8 @@ static int vnet_virtio_io_write(struct guest_info * core, uint16_t port, void *
 
     PrintDebug("VNET Bridge: VIRTIO VNET Write for port %d len=%d, value=%x\n", 
               port, length, *(uint32_t *)src);
-    PrintDebug("VNET Bridge: port idx=%d\n", port_idx);
 
     vnet_state->total_exit ++;
-
     switch (port_idx) {
        case GUEST_FEATURES_PORT:
            if (length != 4) {
@@ -467,13 +456,14 @@ static int vnet_virtio_io_write(struct guest_info * core, uint16_t port, void *
 
                if(vnet_state->queue[RECV_QUEUE].avail != NULL){
                    vnet_state->ready = 1;
+                   vnet_state->queue[RECV_QUEUE].used->flags |= VRING_NO_NOTIFY_FLAG;
                }
 
                //No notify when there is pkt tx from guest
+               //palacios will do the polling
                if(vnet_state->queue[XMIT_QUEUE].used != NULL){
                    vnet_state->queue[XMIT_QUEUE].used->flags |= VRING_NO_NOTIFY_FLAG;
                }
-               
            } else {
                PrintError("Illegal write length for page frame number\n");
                return -1;
@@ -506,8 +496,7 @@ static int vnet_virtio_io_write(struct guest_info * core, uint16_t port, void *
                    PrintError("Could not handle Virtio VNET TX\n");
                    return -1;
                }
-               vnet_state->tx_exit ++;
-               //PrintError("Notify on TX\n");
+               PrintError("Notify on TX\n");
            } else if (queue_idx == 2) {
                if (handle_rx_kick(core, vnet_state) == -1){
                    PrintError("Could not handle Virtio RX buffer refills Kick\n");
@@ -624,9 +613,9 @@ static int dev_init(struct v3_vm_info * vm, v3_cfg_tree_t * cfg) {
     struct vm_device * pci_bus = v3_find_dev(vm, v3_cfg_val(cfg, "bus"));
     struct virtio_vnet_state * vnet_state = NULL;
     struct pci_device * pci_dev = NULL;
-    char * dev_id = v3_cfg_val(cfg, "ID");
+    char * name = v3_cfg_val(cfg, "name");
 
-    PrintDebug("VNET Bridge: Initializing VNET Bridge Control device: %s\n", dev_id);
+    PrintDebug("VNET Bridge: Initializing VNET Bridge Control device: %s\n", name);
 
     if (pci_bus == NULL) {
        PrintError("VNET Bridge device require a PCI Bus");
@@ -638,10 +627,10 @@ static int dev_init(struct v3_vm_info * vm, v3_cfg_tree_t * cfg) {
        
     vnet_state->vm = vm;
 
-    struct vm_device * dev = v3_allocate_device(dev_id, &dev_ops, vnet_state);
+    struct vm_device * dev = v3_allocate_device(name, &dev_ops, vnet_state);
 
     if (v3_attach_device(vm, dev) == -1) {
-       PrintError("Could not attach device %s\n", dev_id);
+       PrintError("Could not attach device %s\n", name);
        return -1;
     }
 
@@ -679,7 +668,7 @@ static int dev_init(struct v3_vm_info * vm, v3_cfg_tree_t * cfg) {
        bars[0].private_data = vnet_state;
 
        pci_dev = v3_pci_register_device(pci_bus, PCI_STD_DEVICE, 
-                                        0, PCI_AUTO_DEV_NUM, 0,
+                                        0, 5 /*PCI_AUTO_DEV_NUM*/, 0,
                                         "LNX_VIRTIO_VNET", bars,
                                         NULL, NULL, NULL, vnet_state);
 
@@ -704,9 +693,13 @@ static int dev_init(struct v3_vm_info * vm, v3_cfg_tree_t * cfg) {
 
     virtio_reset(vnet_state);
 
-    V3_Print("Registering Virtio device as vnet bridge\n");
-    v3_vnet_add_bridge(vm, vnet_pkt_input_cb, vnet_pkt_input_xcall, polling_pkt_from_guest, 0, 500000, (void *)vnet_state);
+    struct v3_vnet_bridge_ops brg_ops;
+    brg_ops.input = vnet_pkt_input_cb;
+    brg_ops.polling_pkt = vnet_virtio_poll;
+    brg_ops.xcall_input = vnet_pkt_input_xcall;
 
+    V3_Print("Registering Virtio device as vnet bridge\n");
+    v3_vnet_add_bridge(vm, &brg_ops, (void *)vnet_state);
 
     return 0;
 }