Palacios Public Git Repository

To checkout Palacios execute

  git clone http://v3vee.org/palacios/palacios.web/palacios.git
This will give you the master branch. You probably want the devel branch or one of the release branches. To switch to the devel branch, simply execute
  cd palacios
  git checkout --track -b devel origin/devel
The other branches are similar.


Now correctly boots 2, 4, 8 core kitten
[palacios.git] / palacios / src / devices / icc_bus.c
index e75734d..c02e7f5 100644 (file)
 #endif
 
 
-void v3_force_exit() {
+void v3_force_exit(void *p) {
+#ifdef CONFIG_DEBUG_ICC_BUS
+    struct guest_info *core=(struct guest_info *)p;
+#endif
+    PrintDebug("core %u: Forced to exit!\n",core->cpu_id);
 }
 
 struct ipi_thunk_data {
@@ -64,7 +68,7 @@ static struct v3_device_ops dev_ops = {
     .stop = NULL,
 };
 
-
+#ifdef CONFIG_DEBUG_ICC_BUS
 static char *shorthand_str[] = { 
     "(no shorthand)",
     "(self)",
@@ -80,21 +84,30 @@ static char *deliverymode_str[] = {
     "(NMI)",
     "(INIT)",
     "(Start Up)",
-    "(reserved)",
+    "(ExtInt)",
 };
+#endif
 
 
-
-static int deliver(uint32_t src_apic, struct apic_data *dest_apic, struct int_cmd_reg *icr, struct icc_bus_state * state) {
+static int deliver(uint32_t src_apic, struct apic_data *dest_apic, struct int_cmd_reg *icr, struct icc_bus_state * state, uint32_t extirq) {
 
     switch (icr->del_mode) {                                           
 
        case 0:  //fixed
        case 1: // lowest priority
-           PrintDebug("icc_bus: delivering to core %u\n",dest_apic->core->cpu_id); 
-           dest_apic->ops->raise_intr(dest_apic->core, icr->vec, dest_apic->priv_data); 
+       case 7: // ExtInt
+           PrintDebug("icc_bus: delivering IRQ to core %u\n",dest_apic->core->cpu_id); 
+           dest_apic->ops->raise_intr(dest_apic->core, 
+                                      icr->del_mode!=7 ? icr->vec : extirq,
+                                      dest_apic->priv_data); 
            if (src_apic!=state->ioapic_id && dest_apic->core->cpu_id != src_apic) { 
+               // Assume core # is same as logical processor for now
+               // TODO FIX THIS FIX THIS
+               // THERE SHOULD BE:  guestapicid->virtualapicid map,
+               //                   cpu_id->logical processor map
+               //     host maitains logical proc->phsysical proc
                PrintDebug("icc_bus: non-local core, forcing it to exit\n"); 
+               V3_Call_On_CPU(dest_apic->core->cpu_id,v3_force_exit,(void*)(dest_apic->core));
                // TODO: do what the print says
            }                                                   
            break;                                                      
@@ -105,7 +118,6 @@ static int deliver(uint32_t src_apic, struct apic_data *dest_apic, struct int_cm
            break;                                                      
            
        case 3:  //reserved                                             
-       case 7:
            PrintError("icc_bus: Reserved delivery mode 3 is unsupported\n"); 
            return -1;                                          
            break;                                                      
@@ -115,14 +127,70 @@ static int deliver(uint32_t src_apic, struct apic_data *dest_apic, struct int_cm
            return -1;                                          
            break;                                                      
 
-       case 5: //INIT
-           PrintError("icc_bus: INIT delivery is unsupported\n"); 
-           return -1;                                          
+       case 5: { //INIT
+           struct guest_info *core = dest_apic->core;
+
+           PrintDebug("icc_bus: INIT delivery to core %u\n",core->cpu_id);
+
+           // TODO: any APIC reset on dest core (shouldn't be needed, but not sure...)
+
+           // Sanity check
+           if (core->cpu_mode!=INIT) { 
+               PrintError("icc_bus: Warning: core %u is not in INIT state, ignored\n",core->cpu_id);
+               // Only a warning, since INIT INIT SIPI is common
+               break;
+           }
+
+           // We transition the target core to SIPI state
+           core->cpu_mode=SIPI;  // note: locking should not be needed here
+
+           // That should be it since the target core should be
+           // waiting in host on this transition
+           // either it's on another core or on a different preemptive thread
+           // in both cases, it will quickly notice this transition 
+           // in particular, we should not need to force an exit here
+
+           PrintDebug("icc_bus: INIT delivery done\n");
+
+       }
            break;                                                      
 
-       case 6: //Start Up
-           PrintError("icc_bus: Startup Delivery is unsupported\n"); 
-           return -1;                                          
+       case 6: { //SIPI
+           struct guest_info *core = dest_apic->core;
+
+           // Sanity check
+           if (core->cpu_mode!=SIPI) { 
+               PrintError("icc_bus: core %u is not in SIPI state, ignored!\n",core->cpu_id);
+               break;
+           }
+
+           // Write the RIP, CS, and descriptor
+           // assume the rest is already good to go
+           //
+           // vector VV -> rip at 0
+           //              CS = VV00
+           //  This means we start executing at linear address VV000
+           //
+           // So the selector needs to be VV00
+           // and the base needs to be VV000
+           //
+           core->rip=0;
+           core->segments.cs.selector = icr->vec<<8;
+           core->segments.cs.limit= 0xffff;
+           core->segments.cs.base = icr->vec<<12;
+
+           PrintDebug("icc_bus: SIPI delivery (0x%x -> 0x%x:0x0) to core %u\n",
+                      icr->vec, core->segments.cs.selector, core->cpu_id);
+           // Maybe need to adjust the APIC?
+           
+           // We transition the target core to SIPI state
+           core->cpu_mode=REAL;  // note: locking should not be needed here
+
+           // As with INIT, we should not need to do anything else
+
+           PrintDebug("icc_bus: SIPI delivery done\n");
+
+       }
            break;                                                      
     }
 
@@ -130,10 +198,13 @@ static int deliver(uint32_t src_apic, struct apic_data *dest_apic, struct int_cm
 } 
 
 
+//
+// icr_data contains interrupt vector *except* for ext_int
+// in which case it is given via irq
+//
+int v3_icc_send_ipi(struct vm_device * icc_bus, uint32_t src_apic, uint64_t icr_data, uint32_t extirq) {
 
-int v3_icc_send_ipi(struct vm_device * icc_bus, uint32_t src_apic, uint64_t icr_data) {
-
-    PrintDebug("icc_bus: icc_bus=%p, src_apic=%u, icr_data=%llx\n",icc_bus,src_apic,icr_data);
+    PrintDebug("icc_bus: icc_bus=%p, src_apic=%u, icr_data=%llx, extirq=%u\n",icc_bus,src_apic,icr_data,extirq);
 
     struct int_cmd_reg *icr = (struct int_cmd_reg *)&icr_data;
     struct icc_bus_state * state = (struct icc_bus_state *)icc_bus->private_data;
@@ -150,10 +221,10 @@ int v3_icc_send_ipi(struct vm_device * icc_bus, uint32_t src_apic, uint64_t icr_
     
     struct apic_data * dest_apic =  &(state->apics[icr->dst]);
 
-
-    PrintDebug("icc_bus: IPI %s %u from %s %u to %s %u (icr=0x%llx)\n",
+    PrintDebug("icc_bus: IPI %s %u from %s %u to %s %u (icr=0x%llx) (extirq=%u)\n",
               deliverymode_str[icr->del_mode], icr->vec, src_apic==state->ioapic_id ? "ioapic" : "apic",
-              src_apic, shorthand_str[icr->dst_shorthand], icr->dst,icr->val);
+              src_apic, shorthand_str[icr->dst_shorthand], icr->dst,icr->val,
+              extirq);
 
 
 
@@ -161,7 +232,7 @@ int v3_icc_send_ipi(struct vm_device * icc_bus, uint32_t src_apic, uint64_t icr_
     switch (icr->dst_shorthand) {
 
        case 0:  // no shorthand
-           if (deliver(src_apic,dest_apic,icr,state)) { 
+           if (deliver(src_apic,dest_apic,icr,state,extirq)) { 
                return -1;
            }
            break;
@@ -171,7 +242,7 @@ int v3_icc_send_ipi(struct vm_device * icc_bus, uint32_t src_apic, uint64_t icr_
                PrintError("icc_bus: ioapic attempting to send to itself\n");
                return -1;
            }
-           if (deliver(src_apic,dest_apic,icr,state)) { 
+           if (deliver(src_apic,dest_apic,icr,state,extirq)) { 
                return -1;
            }
            break;
@@ -182,7 +253,7 @@ int v3_icc_send_ipi(struct vm_device * icc_bus, uint32_t src_apic, uint64_t icr_
            for (i=0;i<MAX_APICS;i++) { 
                dest_apic=&(state->apics[i]);
                if (dest_apic->present && (i!=src_apic || icr->dst_shorthand==2)) { 
-                   if (deliver(src_apic,dest_apic,icr,state)) { 
+                   if (deliver(src_apic,dest_apic,icr,state,extirq)) { 
                        return -1;
                    }
                }