init_socket(struct raw_interface * iface, const char * eth_dev){
int err;
struct sockaddr_ll sock_addr;
- struct ifreq if_req;
+ struct net_device * net_dev;
err = sock_create(PF_PACKET, SOCK_RAW, htons(ETH_P_ALL), &(iface->raw_sock));
if (err < 0) {
return -1;
}
- memset(&if_req, 0, sizeof(if_req));
- strncpy(if_req.ifr_name, eth_dev, sizeof(if_req.ifr_name));
-
- err = iface->raw_sock->ops->ioctl(iface->raw_sock, SIOCGIFINDEX, (long)&if_req);
- if (err < 0){
- printk(KERN_WARNING "Palacios Packet: Unable to get index for device %s, error %d\n",
- if_req.ifr_name, err);
-
+ net_dev = dev_get_by_name(&init_net, eth_dev);
+ if(net_dev == NULL) {
+ printk(KERN_WARNING "Palacios Packet: Unable to get index for device %s\n", eth_dev);
sock_release(iface->raw_sock);
return -1;
}
memset(&sock_addr, 0, sizeof(sock_addr));
sock_addr.sll_family = PF_PACKET;
sock_addr.sll_protocol = htons(ETH_P_ALL);
- sock_addr.sll_ifindex = if_req.ifr_ifindex;
+ sock_addr.sll_ifindex = net_dev->ifindex;
err = iface->raw_sock->ops->bind(iface->raw_sock,
(struct sockaddr *)&sock_addr,
}
printk(KERN_INFO "Bind a palacios raw packet interface to device %s, device index %d\n",
- if_req.ifr_name, if_req.ifr_ifindex);
+ eth_dev, net_dev->ifindex);
return 0;
}
static void inline
deinit_raw_interface(struct raw_interface * iface){
- struct v3_packet * recver_state;
+ struct v3_packet * recver_state, * tmp_state;
kthread_stop(iface->recv_thread);
sock_release(iface->raw_sock);
palacios_free_htable(iface->mac_to_recver, 0, 0);
- list_for_each_entry(recver_state, &(iface->brdcast_recvers), node) {
+ list_for_each_entry_safe(recver_state, tmp_state, &(iface->brdcast_recvers), node) {
kfree(recver_state);
}
}
unsigned long flags;
spin_lock_irqsave(&(packet_state.lock), flags);
-
iface = find_interface(host_nic);
+ spin_unlock_irqrestore(&(packet_state.lock),flags);
+
if(iface == NULL){
iface = (struct raw_interface *)kmalloc(sizeof(struct raw_interface), GFP_KERNEL);
+ if (!iface) {
+ printk("Palacios Packet Interface: Fails to allocate interface\n");
+ return -1;
+ }
if(init_raw_interface(iface, host_nic) != 0) {
printk("Palacios Packet Interface: Fails to initiate an raw interface on device %s\n", host_nic);
kfree(iface);
- spin_unlock_irqrestore(&(packet_state.lock), flags);
-
return -1;
}
-
+ spin_lock_irqsave(&(packet_state.lock), flags);
list_add(&(iface->node), &(packet_state.open_interfaces));
+ spin_unlock_irqrestore(&(packet_state.lock),flags);
}
- spin_unlock_irqrestore(&(packet_state.lock), flags);
-
packet->host_packet_data = iface;
list_add(&(packet->node), &(iface->brdcast_recvers));
}
static int packet_deinit( void ) {
- struct raw_interface * iface;
+ struct raw_interface * iface, * tmp;
- list_for_each_entry(iface, &(packet_state.open_interfaces), node) {
+ list_for_each_entry_safe(iface, tmp, &(packet_state.open_interfaces), node) {
deinit_raw_interface(iface);
kfree(iface);
}