X-Git-Url: http://v3vee.org/palacios/gitweb/gitweb.cgi?a=blobdiff_plain;f=palacios%2Fsrc%2Fpalacios%2Fvmx_msr.c;h=18bb3ee5cfee8e157291d89185c7517b9c43c7ea;hb=198151f1d58834ff7889389007232a3d250f51f1;hp=bb70fa7ef50de4fd83e398e70c4069653c8423d6;hpb=b7093fd3602ef2c796a1f8a0daded9d6aad0b756;p=palacios.git

diff --git a/palacios/src/palacios/vmx_msr.c b/palacios/src/palacios/vmx_msr.c
index bb70fa7..18bb3ee 100644
--- a/palacios/src/palacios/vmx_msr.c
+++ b/palacios/src/palacios/vmx_msr.c
@@ -31,12 +31,13 @@
 
 static int get_bitmap_index(uint_t msr)
 {
+    // unsigned comparison with 0 here for clarity
     if( (msr >= LOW_MSR_START) && msr <= LOW_MSR_END) {
         return LOW_MSR_INDEX + msr;
     } else if (( msr >= HIGH_MSR_START ) && (msr <= HIGH_MSR_END)) {
         return (HIGH_MSR_INDEX * 8) + (msr - HIGH_MSR_START);
     } else {
-        PrintError("MSR out of range: 0x%x\n", msr);
+        PrintError(VM_NONE, VCORE_NONE,  "MSR out of range: 0x%x\n", msr);
         return -1;
     }
 }
@@ -73,9 +74,9 @@ int v3_init_vmx_msr_map(struct v3_vm_info * vm) {
 
     msr_map->update_map = update_map;
     
-    temp = V3_AllocPages(1);
+    temp = V3_AllocPages(1); // need not be shadow-safe, not exposed to guest
     if (!temp) { 
-	PrintError("Cannot allocat MSR bitmap\n");
+        PrintError(vm, VCORE_NONE, "Cannot allocat MSR bitmap\n");
 	return -1;
     }
     msr_map->arch_data = V3_VAddr(temp);