X-Git-Url: http://v3vee.org/palacios/gitweb/gitweb.cgi?a=blobdiff_plain;f=palacios%2Fsrc%2Fpalacios%2Fvmm.c;h=e9a3a9df7d1f22fe2af3179cb60d92376e9714b5;hb=d597d493eb303496f3bb32e2a73a094a8a20a022;hp=ff5a55cb13180c006124b77c4c6b018519e20ce9;hpb=b114cb5ecaeb5e330511684a1c8d56e23fb2f136;p=palacios.git diff --git a/palacios/src/palacios/vmm.c b/palacios/src/palacios/vmm.c index ff5a55c..e9a3a9d 100644 --- a/palacios/src/palacios/vmm.c +++ b/palacios/src/palacios/vmm.c @@ -255,6 +255,12 @@ int v3_start_vm(struct v3_vm_info * vm, unsigned int cpu_mask) { uint32_t avail_cores = 0; int vcore_id = 0; + + if (vm->run_state != VM_STOPPED) { + PrintError("VM has already been launched (state=%d)\n", (int)vm->run_state); + return -1; + } + /// CHECK IF WE ARE MULTICORE ENABLED.... V3_Print("V3 -- Starting VM (%u cores)\n", vm->num_cores); @@ -474,7 +480,7 @@ int v3_stop_vm(struct v3_vm_info * vm) { break; } - v3_yield(NULL); + v3_yield(NULL,-1); } V3_Print("VM stopped. Returning\n"); @@ -522,7 +528,7 @@ static int sim_callback(struct guest_info * core, void * private_data) { V3_Print("Simulation callback activated (guest_rip=%p)\n", (void *)core->rip); while (v3_bitmap_check(timeout_map, core->vcpu_id) == 1) { - v3_yield(NULL); + v3_yield(NULL,-1); } return 0; @@ -593,7 +599,7 @@ int v3_simulate_vm(struct v3_vm_info * vm, unsigned int msecs) { break; } - v3_yield(NULL); + v3_yield(NULL,-1); } @@ -679,17 +685,10 @@ v3_cpu_mode_t v3_get_host_cpu_mode() { #endif -#define V3_Yield(addr) \ - do { \ - extern struct v3_os_hooks * os_hooks; \ - if ((os_hooks) && (os_hooks)->yield_cpu) { \ - (os_hooks)->yield_cpu(); \ - } \ - } while (0) \ -void v3_yield_cond(struct guest_info * info) { +void v3_yield_cond(struct guest_info * info, int usec) { uint64_t cur_cycle; cur_cycle = v3_get_host_time(&info->time_state); @@ -698,7 +697,12 @@ void v3_yield_cond(struct guest_info * info) { // (void *)cur_cycle, (void *)info->yield_start_cycle, // (void *)info->yield_cycle_period); - V3_Yield(); + if (usec < 0) { + V3_Yield(); + } else { + V3_Yield_Timed(usec); + } + info->yield_start_cycle += info->vm_info->yield_cycle_period; } } @@ -708,9 +712,16 @@ void v3_yield_cond(struct guest_info * info) { * unconditional cpu yield * if the yielding thread is a guest context, the guest quantum is reset on resumption * Non guest context threads should call this function with a NULL argument - */ -void v3_yield(struct guest_info * info) { - V3_Yield(); + * + * usec <0 => the non-timed yield is used + * usec >=0 => the timed yield is used, which also usually implies interruptible + */ +void v3_yield(struct guest_info * info, int usec) { + if (usec < 0) { + V3_Yield(); + } else { + V3_Yield_Timed(usec); + } if (info) { info->yield_start_cycle += info->vm_info->yield_cycle_period;