X-Git-Url: http://v3vee.org/palacios/gitweb/gitweb.cgi?a=blobdiff_plain;f=palacios%2Fsrc%2Fpalacios%2Fvm_guest_mem.c;h=e2ca0bf929f2e8a84b1773248e1bceaaf470815d;hb=9b78fe7d41b07fd135eae2282cc18ccb964e7de3;hp=7e45c0caf83d4834bd404df5b9efc7d75ecec459;hpb=9ed850393ba752a7c0bb83673b5ff98f9573f2da;p=palacios.git diff --git a/palacios/src/palacios/vm_guest_mem.c b/palacios/src/palacios/vm_guest_mem.c index 7e45c0c..e2ca0bf 100644 --- a/palacios/src/palacios/vm_guest_mem.c +++ b/palacios/src/palacios/vm_guest_mem.c @@ -15,9 +15,11 @@ int host_va_to_host_pa(addr_t host_va, addr_t * host_pa) { *host_pa = (addr_t)(os_hooks)->vaddr_to_paddr((void *)host_va); if (*host_pa == 0) { + PrintError("In HVA->HPA: Invalid HVA(%x)->HPA lookup\n", host_va); return -1; } } else { + PrintError("In HVA->HPA: os_hooks not defined\n"); return -1; } return 0; @@ -30,9 +32,11 @@ int host_pa_to_host_va(addr_t host_pa, addr_t * host_va) { *host_va = (addr_t)(os_hooks)->paddr_to_vaddr((void *)host_pa); if (*host_va == 0) { + PrintError("In HPA->HVA: Invalid HPA(%x)->HVA lookup\n", host_pa); return -1; } } else { + PrintError("In HPA->HVA: os_hooks not defined\n"); return -1; } return 0; @@ -43,7 +47,7 @@ int host_pa_to_host_va(addr_t host_pa, addr_t * host_va) { int guest_pa_to_host_pa(struct guest_info * guest_info, addr_t guest_pa, addr_t * host_pa) { // we use the shadow map here... if (lookup_shadow_map_addr(&(guest_info->mem_map), guest_pa, host_pa) != HOST_REGION_PHYSICAL_MEMORY) { - PrintDebug("Could not find address in shadow map (addr=%x)\n", guest_pa); + PrintError("In GPA->HPA: Could not find address in shadow map (addr=%x)\n", guest_pa); return -1; } @@ -57,6 +61,7 @@ int guest_pa_to_host_pa(struct guest_info * guest_info, addr_t guest_pa, addr_t // int host_pa_to_guest_pa(struct guest_info * guest_info, addr_t host_pa, addr_t * guest_pa) { *guest_pa = 0; + PrintError("ERROR!!! HPA->GPA currently not implemented!!!\n"); return -1; } @@ -71,14 +76,16 @@ int host_pa_to_guest_pa(struct guest_info * guest_info, addr_t host_pa, addr_t * /* !! Currently not implemented !! */ // This will return negative until we implement host_pa_to_guest_pa() int host_va_to_guest_pa(struct guest_info * guest_info, addr_t host_va, addr_t * guest_pa) { - addr_t host_pa; + addr_t host_pa = 0; *guest_pa = 0; if (host_va_to_host_pa(host_va, &host_pa) != 0) { + PrintError("In HVA->GPA: Invalid HVA(%x)->HPA lookup\n", host_va); return -1; } if (host_pa_to_guest_pa(guest_info, host_pa, guest_pa) != 0) { + PrintError("In HVA->GPA: Invalid HPA(%x)->GPA lookup\n", host_pa); return -1; } @@ -89,15 +96,17 @@ int host_va_to_guest_pa(struct guest_info * guest_info, addr_t host_va, addr_t * int guest_pa_to_host_va(struct guest_info * guest_info, addr_t guest_pa, addr_t * host_va) { - addr_t host_pa; + addr_t host_pa = 0; *host_va = 0; if (guest_pa_to_host_pa(guest_info, guest_pa, &host_pa) != 0) { + PrintError("In GPA->HVA: Invalid GPA(%x)->HPA lookup\n", guest_pa); return -1; } if (host_pa_to_host_va(host_pa, host_va) != 0) { + PrintError("In GPA->HVA: Invalid HPA(%x)->HVA lookup\n", host_pa); return -1; } @@ -106,70 +115,79 @@ int guest_pa_to_host_va(struct guest_info * guest_info, addr_t guest_pa, addr_t int guest_va_to_guest_pa(struct guest_info * guest_info, addr_t guest_va, addr_t * guest_pa) { - if (guest_info->page_mode == SHADOW_PAGING) { - switch (guest_info->cpu_mode) { - case REAL: - case PROTECTED: - case LONG: - case PROTECTED_PAE: - // guest virtual address is the same as the physical - *guest_pa = guest_va; - return 0; - case PROTECTED_PG: - { - addr_t tmp_pa; - pde32_t * pde; - addr_t guest_pde = CR3_TO_PDE32(guest_info->shdw_pg_state.guest_cr3); - - if (guest_pa_to_host_va(guest_info, guest_pde, (addr_t *)&pde) == -1) { - return -1; - } + if (guest_info->mem_mode == PHYSICAL_MEM) { + // guest virtual address is the same as the physical + *guest_pa = guest_va; + return 0; + } - switch (pde32_lookup(pde, guest_va, &tmp_pa)) { - case PDE32_ENTRY_NOT_PRESENT: - *guest_pa = 0; - return -1; - case PDE32_ENTRY_LARGE_PAGE: - *guest_pa = tmp_pa; - return 0; - case PDE32_ENTRY_PTE32: - { - pte32_t * pte; - - if (guest_pa_to_host_va(guest_info, tmp_pa, (addr_t*)&pte) == -1) { - return -1; - } - - if (pte32_lookup(pte, guest_va, guest_pa) != 0) { - return -1; - } - - return 0; - } - default: - return -1; - } + + + // Guest Is in Paged mode + switch (guest_info->cpu_mode) { + case PROTECTED: + { + addr_t tmp_pa = 0; + pde32_t * pde = 0; + addr_t guest_pde = 0; + + if (guest_info->shdw_pg_mode == SHADOW_PAGING) { + guest_pde = CR3_TO_PDE32(guest_info->shdw_pg_state.guest_cr3); + } else if (guest_info->shdw_pg_mode == NESTED_PAGING) { + guest_pde = CR3_TO_PDE32(guest_info->ctrl_regs.cr3); } - case PROTECTED_PAE_PG: - { - // Fill in - } - case LONG_PG: + + if (guest_pa_to_host_va(guest_info, guest_pde, (addr_t *)&pde) == -1) { + PrintError("In GVA->GPA: Invalid GPA(%x)->HVA PDE32 lookup\n", guest_pde); + return -1; + } + + + switch (pde32_lookup(pde, guest_va, &tmp_pa)) { + case PDE32_ENTRY_NOT_PRESENT: + *guest_pa = 0; + return -1; + case PDE32_ENTRY_LARGE_PAGE: + *guest_pa = tmp_pa; + return 0; + case PDE32_ENTRY_PTE32: { - // Fill in + pte32_t * pte = 0; + + + if (guest_pa_to_host_va(guest_info, tmp_pa, (addr_t*)&pte) == -1) { + PrintError("In GVA->GPA: Invalid GPA(%x)->HVA PTE32 lookup\n", guest_pa); + return -1; + } + + //PrintDebug("PTE host addr=%x, GVA=%x, GPA=%x(should be 0)\n", pte, guest_va, *guest_pa); + + if (pte32_lookup(pte, guest_va, guest_pa) != 0) { + PrintError("In GVA->GPA: PTE32 Lookup failure GVA=%x; PTE=%x\n", guest_va, pte); + // PrintPT32(PDE32_INDEX(guest_va) << 22, pte); + return -1; + } + + return 0; } - default: - return -1; + default: + return -1; + } } - } else if (guest_info->page_mode == NESTED_PAGING) { - - // Fill in - - } else { + case PROTECTED_PAE: + { + // Fill in + } + case LONG: + { + // Fill in + } + default: return -1; } - - + + + return 0; } @@ -182,6 +200,7 @@ int guest_va_to_guest_pa(struct guest_info * guest_info, addr_t guest_va, addr_t */ int guest_pa_to_guest_va(struct guest_info * guest_info, addr_t guest_pa, addr_t * guest_va) { *guest_va = 0; + PrintError("ERROR!!: GPA->GVA Not Implemented!!\n"); return -1; } @@ -192,15 +211,17 @@ int guest_pa_to_guest_va(struct guest_info * guest_info, addr_t guest_pa, addr_t int guest_va_to_host_pa(struct guest_info * guest_info, addr_t guest_va, addr_t * host_pa) { - addr_t guest_pa; + addr_t guest_pa = 0; *host_pa = 0; if (guest_va_to_guest_pa(guest_info, guest_va, &guest_pa) != 0) { + PrintError("In GVA->HPA: Invalid GVA(%x)->GPA lookup\n", guest_va); return -1; } if (guest_pa_to_host_pa(guest_info, guest_pa, host_pa) != 0) { + PrintError("In GVA->HPA: Invalid GPA(%x)->HPA lookup\n", guest_pa); return -1; } @@ -209,15 +230,17 @@ int guest_va_to_host_pa(struct guest_info * guest_info, addr_t guest_va, addr_t /* !! Currently not implemented !! */ int host_pa_to_guest_va(struct guest_info * guest_info, addr_t host_pa, addr_t * guest_va) { - addr_t guest_pa; + addr_t guest_pa = 0; *guest_va = 0; if (host_pa_to_guest_pa(guest_info, host_pa, &guest_pa) != 0) { + PrintError("In HPA->GVA: Invalid HPA(%x)->GPA lookup\n", host_pa); return -1; } if (guest_pa_to_guest_va(guest_info, guest_pa, guest_va) != 0) { + PrintError("In HPA->GVA: Invalid GPA(%x)->GVA lookup\n", guest_pa); return -1; } @@ -228,20 +251,23 @@ int host_pa_to_guest_va(struct guest_info * guest_info, addr_t host_pa, addr_t * int guest_va_to_host_va(struct guest_info * guest_info, addr_t guest_va, addr_t * host_va) { - addr_t guest_pa; - addr_t host_pa; + addr_t guest_pa = 0; + addr_t host_pa = 0; *host_va = 0; if (guest_va_to_guest_pa(guest_info, guest_va, &guest_pa) != 0) { + PrintError("In GVA->HVA: Invalid GVA(%x)->GPA lookup\n", guest_va); return -1; } if (guest_pa_to_host_pa(guest_info, guest_pa, &host_pa) != 0) { + PrintError("In GVA->HVA: Invalid GPA(%x)->HPA lookup\n", guest_pa); return -1; } if (host_pa_to_host_va(host_pa, host_va) != 0) { + PrintError("In GVA->HVA: Invalid HPA(%x)->HVA lookup\n", host_pa); return -1; } @@ -251,20 +277,23 @@ int guest_va_to_host_va(struct guest_info * guest_info, addr_t guest_va, addr_t /* !! Currently not implemented !! */ int host_va_to_guest_va(struct guest_info * guest_info, addr_t host_va, addr_t * guest_va) { - addr_t host_pa; - addr_t guest_pa; + addr_t host_pa = 0; + addr_t guest_pa = 0; *guest_va = 0; if (host_va_to_host_pa(host_va, &host_pa) != 0) { + PrintError("In HVA->GVA: Invalid HVA(%x)->HPA lookup\n", host_va); return -1; } if (host_pa_to_guest_pa(guest_info, host_pa, &guest_pa) != 0) { + PrintError("In HVA->GVA: Invalid HPA(%x)->GPA lookup\n", host_va); return -1; } if (guest_pa_to_guest_va(guest_info, guest_pa, guest_va) != 0) { + PrintError("In HVA->GVA: Invalid GPA(%x)->GVA lookup\n", guest_pa); return -1; } @@ -283,14 +312,20 @@ int read_guest_va_memory(struct guest_info * guest_info, addr_t guest_va, int co addr_t cursor = guest_va; int bytes_read = 0; + + while (count > 0) { int dist_to_pg_edge = (PAGE_ADDR(cursor) + PAGE_SIZE) - cursor; int bytes_to_copy = (dist_to_pg_edge > count) ? count : dist_to_pg_edge; - addr_t host_addr; + addr_t host_addr = 0; + if (guest_va_to_host_va(guest_info, cursor, &host_addr) != 0) { + PrintDebug("Invalid GVA(%x)->HVA lookup\n", cursor); return bytes_read; } + + memcpy(dest + bytes_read, (void*)host_addr, bytes_to_copy); @@ -317,12 +352,11 @@ int read_guest_pa_memory(struct guest_info * guest_info, addr_t guest_pa, int co while (count > 0) { int dist_to_pg_edge = (PAGE_ADDR(cursor) + PAGE_SIZE) - cursor; int bytes_to_copy = (dist_to_pg_edge > count) ? count : dist_to_pg_edge; - addr_t host_addr; + addr_t host_addr = 0; if (guest_pa_to_host_va(guest_info, cursor, &host_addr) != 0) { return bytes_read; - } - + } /* PrintDebug("Trying to read %d bytes\n", bytes_to_copy);