X-Git-Url: http://v3vee.org/palacios/gitweb/gitweb.cgi?a=blobdiff_plain;f=palacios%2Fsrc%2Fpalacios%2Fsvm_io.c;h=91ba65972c612dd67a8620c94e2e68f980fb50d1;hb=3586c3bd6260bf79c57baebf66a26d7e8158d411;hp=1ec4a60a7b37d1c326fddd76e29f4dcd1e517e9e;hpb=4290e5f20a4ea5e5f32cb8228ac4d7446dc1021b;p=palacios.git

diff --git a/palacios/src/palacios/svm_io.c b/palacios/src/palacios/svm_io.c
index 1ec4a60..91ba659 100644
--- a/palacios/src/palacios/svm_io.c
+++ b/palacios/src/palacios/svm_io.c
@@ -17,20 +17,21 @@
  * redistribute, and modify it as specified in the file "V3VEE_LICENSE".
  */
 
+
 #include <palacios/svm_io.h>
 #include <palacios/vmm_io.h>
 #include <palacios/vmm_ctrl_regs.h>
 #include <palacios/vmm_decoder.h>
 #include <palacios/vm_guest_mem.h>
 
-#ifndef CONFIG_DEBUG_IO
+#ifndef V3_CONFIG_DEBUG_IO
 #undef PrintDebug
 #define PrintDebug(fmt, args...)
 #endif
 
 
-static int update_map(struct guest_info * info, uint16_t port, int hook_read, int hook_write) {
-    uchar_t * bitmap = (uint8_t *)(info->io_map.arch_data);;
+static int update_map(struct v3_vm_info * vm, uint16_t port, int hook_read, int hook_write) {
+    uchar_t * bitmap = (uint8_t *)(vm->io_map.arch_data);;
     int major = port / 8;
     int minor = port % 8;
 
@@ -44,32 +45,40 @@ static int update_map(struct guest_info * info, uint16_t port, int hook_read, in
 }
 
 
-int v3_init_svm_io_map(struct guest_info * info) {
-    info->io_map.update_map = update_map;
+int v3_init_svm_io_map(struct v3_vm_info * vm) {
+    void *temp;
+
+    vm->io_map.update_map = update_map;
+
+    temp = V3_AllocPages(3); // need not be shadow-safe, not exposed to guest
+    
+    if (!temp) { 
+	PrintError(vm, VCORE_NONE,  "Cannot allocate io bitmap\n");
+	return -1;
+    }
+
+    vm->io_map.arch_data = V3_VAddr(temp);
 
-    info->io_map.arch_data = V3_VAddr(V3_AllocPages(3));
-    memset(info->io_map.arch_data, 0, PAGE_SIZE_4KB * 3);
+    memset(vm->io_map.arch_data, 0xff, PAGE_SIZE_4KB * 3);
 
 
-    v3_refresh_io_map(info);
+    v3_refresh_io_map(vm);
 
     return 0;
 }
 
+int v3_deinit_svm_io_map(struct v3_vm_info * vm) {
+    V3_FreePages(V3_PAddr(vm->io_map.arch_data), 3);
+    return 0;
+}
+
 
 
 // This should package up an IO request and call vmm_handle_io
-int v3_handle_svm_io_in(struct guest_info * info, struct svm_io_info * io_info) {
-    struct v3_io_hook * hook = v3_get_io_hook(info, io_info->port);
+int v3_handle_svm_io_in(struct guest_info * core, struct svm_io_info * io_info) {
+    struct v3_io_hook * hook = v3_get_io_hook(core->vm_info, io_info->port);
     int read_size = 0;
 
-    if (hook == NULL) {
-	PrintError("Hook Not present for in on port 0x%x\n", io_info->port);
-	// error, we should not have exited on this port
-	return -1;
-    }
-
-
     if (io_info->sz8) { 
 	read_size = 1;
     } else if (io_info->sz16) {
@@ -78,13 +87,21 @@ int v3_handle_svm_io_in(struct guest_info * info, struct svm_io_info * io_info)
 	read_size = 4;
     }
 
-    PrintDebug("IN of %d bytes on port %d (0x%x)\n", read_size, io_info->port, io_info->port);
+    PrintDebug(core->vm_info, core, "IN of %d bytes on port %d (0x%x)\n", read_size, io_info->port, io_info->port);
 
-    if (hook->read(io_info->port, &(info->vm_regs.rax), read_size, hook->priv_data) != read_size) {
-	// not sure how we handle errors.....
-	PrintError("Read Failure for in on port 0x%x\n", io_info->port);
-	return -1;
+    if (hook == NULL) {
+	PrintDebug(core->vm_info, core, "IN operation on unhooked IO port 0x%x - returning zero\n", io_info->port);
+	core->vm_regs.rax >>= 8*read_size;
+	core->vm_regs.rax <<= 8*read_size;
+
+    } else {
+	if (hook->read(core, io_info->port, &(core->vm_regs.rax), read_size, hook->priv_data) != read_size) {
+	    // not sure how we handle errors.....
+	    PrintError(core->vm_info, core, "Read Failure for in on port 0x%x\n", io_info->port);
+	    return -1;
+	}
     }
+    
 
     return 0;
 }
@@ -96,13 +113,13 @@ int v3_handle_svm_io_in(struct guest_info * info, struct svm_io_info * io_info)
 /* We might not handle wrap around of the RDI register correctly...
  * In that if we do wrap around the effect will manifest in the higher bits of the register
  */
-int v3_handle_svm_io_ins(struct guest_info * info, struct svm_io_info * io_info) {
-    struct v3_io_hook * hook = v3_get_io_hook(info, io_info->port);
+int v3_handle_svm_io_ins(struct guest_info * core, struct svm_io_info * io_info) {
+    struct v3_io_hook * hook = v3_get_io_hook(core->vm_info, io_info->port);
     int read_size = 0;
     addr_t dst_addr = 0;
     uint_t rep_num = 1;
     ullong_t mask = 0;
-    struct v3_segment * theseg = &(info->segments.es); // default is ES
+    struct v3_segment * theseg = &(core->segments.es); // default is ES
     addr_t inst_ptr;
 
 
@@ -110,45 +127,37 @@ int v3_handle_svm_io_ins(struct guest_info * info, struct svm_io_info * io_info)
     // direction can equal either 1 or -1
     // We will multiply the final added offset by this value to go the correct direction
     int direction = 1;
-    struct rflags * flags = (struct rflags *)&(info->ctrl_regs.rflags);  
+    struct rflags * flags = (struct rflags *)&(core->ctrl_regs.rflags);  
 
     if (flags->df) {
 	direction = -1;
     }
+    
 
-
-    if (hook == NULL) {
-	PrintError("Hook Not present for ins on port 0x%x\n", io_info->port);
-	// error, we should not have exited on this port
-	return -1;
-    }
-
-
-
-    if (guest_va_to_host_va(info, get_addr_linear(info, info->rip, &(info->segments.cs)), &inst_ptr) == -1) {
-	PrintError("Can't access instruction\n");
+    if (v3_gva_to_hva(core, get_addr_linear(core, core->rip, &(core->segments.cs)), &inst_ptr) == -1) {
+	PrintError(core->vm_info, core, "Can't access instruction\n");
 	return -1;
     }
 
     while (is_prefix_byte(*((char *)inst_ptr))) {
 	switch (*((char *)inst_ptr)) {
 	    case PREFIX_CS_OVERRIDE:
-		theseg = &(info->segments.cs);
+		theseg = &(core->segments.cs);
 		break;
 	    case PREFIX_SS_OVERRIDE:
-		theseg = &(info->segments.ss);
+		theseg = &(core->segments.ss);
 		break;
 	    case PREFIX_DS_OVERRIDE:
-		theseg = &(info->segments.ds);
+		theseg = &(core->segments.ds);
 		break;
 	    case PREFIX_ES_OVERRIDE:
-		theseg = &(info->segments.es);
+		theseg = &(core->segments.es);
 		break;
 	    case PREFIX_FS_OVERRIDE:
-		theseg = &(info->segments.fs);
+		theseg = &(core->segments.fs);
 		break;
 	    case PREFIX_GS_OVERRIDE:
-		theseg = &(info->segments.gs);
+		theseg = &(core->segments.gs);
 		break;
 	    default:
 		break;
@@ -157,7 +166,7 @@ int v3_handle_svm_io_ins(struct guest_info * info, struct svm_io_info * io_info)
     }
 
 
-    PrintDebug("INS on  port %d (0x%x)\n", io_info->port, io_info->port);
+    PrintDebug(core->vm_info, core, "INS on  port %d (0x%x)\n", io_info->port, io_info->port);
 
     if (io_info->sz8) {
 	read_size = 1;
@@ -166,7 +175,7 @@ int v3_handle_svm_io_ins(struct guest_info * info, struct svm_io_info * io_info)
     } else if (io_info->sz32) {
 	read_size = 4;
     } else {
-	PrintError("io_info Invalid Size\n");
+	PrintError(core->vm_info, core, "io_info Invalid Size\n");
 	return -1;
     }
 
@@ -179,44 +188,49 @@ int v3_handle_svm_io_ins(struct guest_info * info, struct svm_io_info * io_info)
 	mask = 0xffffffffffffffffLL;
     } else {
 	// This value should be set depending on the host register size...
-	mask = get_gpr_mask(info);
+	mask = get_gpr_mask(core);
 
-	PrintDebug("INS io_info invalid address size, mask=0x%p, io_info=0x%p\n",
+	PrintDebug(core->vm_info, core, "INS io_info invalid address size, mask=0x%p, io_info=0x%p\n",
 		   (void *)(addr_t)mask, (void *)(addr_t)(io_info));
-	// PrintDebug("INS Aborted... Check implementation\n");
+	// PrintDebug(core->vm_info, core, "INS Aborted... Check implementation\n");
 	//return -1;
     }
 
     if (io_info->rep) {
-	rep_num = info->vm_regs.rcx & mask;
+	rep_num = core->vm_regs.rcx & mask;
 	//rep_num = info->vm_regs.rcx;
     }
 
-
-    PrintDebug("INS size=%d for %d steps\n", read_size, rep_num);
+    PrintDebug(core->vm_info, core, "INS size=%d for %d steps\n", read_size, rep_num);
 
     while (rep_num > 0) {
 	addr_t host_addr;
-	dst_addr = get_addr_linear(info, (info->vm_regs.rdi & mask), theseg);
+	dst_addr = get_addr_linear(core, (core->vm_regs.rdi & mask), theseg);
     
-	//	PrintDebug("Writing 0x%p\n", (void *)dst_addr);
+	//	PrintDebug(core->vm_info, core, "Writing 0x%p\n", (void *)dst_addr);
 
-	if (guest_va_to_host_va(info, dst_addr, &host_addr) == -1) {
+	if (v3_gva_to_hva(core, dst_addr, &host_addr) == -1) {
 	    // either page fault or gpf...
-	    PrintError("Could not convert Guest VA to host VA\n");
+	    PrintError(core->vm_info, core, "Could not convert Guest VA to host VA\n");
 	    return -1;
 	}
 
-	if (hook->read(io_info->port, (char *)host_addr, read_size, hook->priv_data) != read_size) {
-	    // not sure how we handle errors.....
-	    PrintError("Read Failure for ins on port 0x%x\n", io_info->port);
-	    return -1;
+	if (hook == NULL) {
+	    PrintDebug(core->vm_info, core, "INS operation on unhooked IO port 0x%x - returning zeros\n", io_info->port);
+	    memset((char*)host_addr,0,read_size);
+	    
+	} else {
+	    if (hook->read(core, io_info->port, (char *)host_addr, read_size, hook->priv_data) != read_size) {
+		// not sure how we handle errors.....
+		PrintError(core->vm_info, core, "Read Failure for ins on port 0x%x\n", io_info->port);
+		return -1;
+	    }
 	}
-
-	info->vm_regs.rdi += (read_size * direction);
+    
+	core->vm_regs.rdi += (read_size * direction);
 
 	if (io_info->rep) {
-	    info->vm_regs.rcx--;
+	    core->vm_regs.rcx--;
 	}
 
 	rep_num--;
@@ -225,17 +239,10 @@ int v3_handle_svm_io_ins(struct guest_info * info, struct svm_io_info * io_info)
     return 0;
 }
 
-int v3_handle_svm_io_out(struct guest_info * info, struct svm_io_info * io_info) {
-    struct v3_io_hook * hook = v3_get_io_hook(info, io_info->port);
+int v3_handle_svm_io_out(struct guest_info * core, struct svm_io_info * io_info) {
+    struct v3_io_hook * hook = v3_get_io_hook(core->vm_info, io_info->port);
     int write_size = 0;
 
-    if (hook == NULL) {
-	PrintError("Hook Not present for out on port 0x%x\n", io_info->port);
-	// error, we should not have exited on this port
-	return -1;
-    }
-
-
     if (io_info->sz8) { 
 	write_size = 1;
     } else if (io_info->sz16) {
@@ -244,13 +251,18 @@ int v3_handle_svm_io_out(struct guest_info * info, struct svm_io_info * io_info)
 	write_size = 4;
     }
 
-    PrintDebug("OUT of %d bytes on  port %d (0x%x)\n", write_size, io_info->port, io_info->port);
+    PrintDebug(core->vm_info, core, "OUT of %d bytes on  port %d (0x%x)\n", write_size, io_info->port, io_info->port);
 
-    if (hook->write(io_info->port, &(info->vm_regs.rax), write_size, hook->priv_data) != write_size) {
-	// not sure how we handle errors.....
-	PrintError("Write Failure for out on port 0x%x\n", io_info->port);
-	return -1;
+    if (hook == NULL) {
+	PrintDebug(core->vm_info, core, "OUT operation on unhooked IO port 0x%x - ignored\n", io_info->port);
+    } else {
+	if (hook->write(core, io_info->port, &(core->vm_regs.rax), write_size, hook->priv_data) != write_size) {
+	    // not sure how we handle errors.....
+	    PrintError(core->vm_info, core, "Write Failure for out on port 0x%x\n", io_info->port);
+	    return -1;
+	}
     }
+    
 
     return 0;
 }
@@ -260,34 +272,27 @@ int v3_handle_svm_io_out(struct guest_info * info, struct svm_io_info * io_info)
  * In that if we do wrap around the effect will manifest in the higher bits of the register
  */
 
-int v3_handle_svm_io_outs(struct guest_info * info,  struct svm_io_info * io_info) {
+int v3_handle_svm_io_outs(struct guest_info * core, struct svm_io_info * io_info) {
  
-    struct v3_io_hook * hook = v3_get_io_hook(info, io_info->port);
+    struct v3_io_hook * hook = v3_get_io_hook(core->vm_info, io_info->port);
     int write_size = 0;
     addr_t dst_addr = 0;
     uint_t rep_num = 1;
     ullong_t mask = 0;
     addr_t inst_ptr;
-    struct v3_segment * theseg = &(info->segments.es); // default is ES
+    struct v3_segment * theseg = &(core->segments.ds); // default is DS
 
     // This is kind of hacky...
     // direction can equal either 1 or -1
     // We will multiply the final added offset by this value to go the correct direction
     int direction = 1;
-    struct rflags * flags = (struct rflags *)&(info->ctrl_regs.rflags);  
+    struct rflags * flags = (struct rflags *)&(core->ctrl_regs.rflags);  
 
     if (flags->df) {
 	direction = -1;
     }
 
-
-    if (hook == NULL) {
-	PrintError("Hook Not present for outs on port 0x%x\n", io_info->port);
-	// error, we should not have exited on this port
-	return -1;
-    }
-
-    PrintDebug("OUTS on  port %d (0x%x)\n", io_info->port, io_info->port);
+    PrintDebug(core->vm_info, core, "OUTS on  port %d (0x%x)\n", io_info->port, io_info->port);
 
     if (io_info->sz8) { 
 	write_size = 1;
@@ -306,48 +311,48 @@ int v3_handle_svm_io_outs(struct guest_info * info,  struct svm_io_info * io_inf
 	mask = 0xffffffffffffffffLL;
     } else {
 	// This value should be set depending on the host register size...
-	mask = get_gpr_mask(info);
+	mask = get_gpr_mask(core);
 
-	PrintDebug("OUTS io_info invalid address size, mask=0%p, io_info=0x%p\n",
+	PrintDebug(core->vm_info, core, "OUTS io_info invalid address size, mask=0%p, io_info=0x%p\n",
 		   (void *)(addr_t)mask, (void *)(addr_t)io_info);
-	// PrintDebug("INS Aborted... Check implementation\n");
+	// PrintDebug(core->vm_info, core, "INS Aborted... Check implementation\n");
 	//return -1;
 	// should never happen
-	//PrintDebug("Invalid Address length\n");
+	//PrintDebug(core->vm_info, core, "Invalid Address length\n");
 	//return -1;
     }
 
     if (io_info->rep) {
-	rep_num = info->vm_regs.rcx & mask;
+	rep_num = core->vm_regs.rcx & mask;
     }
 
   
 
 
-    if (guest_va_to_host_va(info, get_addr_linear(info, info->rip, &(info->segments.cs)), &inst_ptr) == -1) {
-	PrintError("Can't access instruction\n");
+    if (v3_gva_to_hva(core, get_addr_linear(core, core->rip, &(core->segments.cs)), &inst_ptr) == -1) {
+	PrintError(core->vm_info, core, "Can't access instruction\n");
 	return -1;
     }
 
     while (is_prefix_byte(*((char *)inst_ptr))) {
 	switch (*((char *)inst_ptr)) {
 	    case PREFIX_CS_OVERRIDE:
-		theseg = &(info->segments.cs);
+		theseg = &(core->segments.cs);
 		break;
 	    case PREFIX_SS_OVERRIDE:
-		theseg = &(info->segments.ss);
+		theseg = &(core->segments.ss);
 		break;
 	    case PREFIX_DS_OVERRIDE:
-		theseg = &(info->segments.ds);
+		theseg = &(core->segments.ds);
 		break;
 	    case PREFIX_ES_OVERRIDE:
-		theseg = &(info->segments.es);
+		theseg = &(core->segments.es);
 		break;
 	    case PREFIX_FS_OVERRIDE:
-		theseg = &(info->segments.fs);
+		theseg = &(core->segments.fs);
 		break;
 	    case PREFIX_GS_OVERRIDE:
-		theseg = &(info->segments.gs);
+		theseg = &(core->segments.gs);
 		break;
 	    default:
 		break;
@@ -355,27 +360,33 @@ int v3_handle_svm_io_outs(struct guest_info * info,  struct svm_io_info * io_inf
 	inst_ptr++;
     }
 
-    PrintDebug("OUTS size=%d for %d steps\n", write_size, rep_num);
+    PrintDebug(core->vm_info, core, "OUTS size=%d for %d steps\n", write_size, rep_num);
 
     while (rep_num > 0) {
-	addr_t host_addr;
+	addr_t host_addr = 0;
 
-	dst_addr = get_addr_linear(info, (info->vm_regs.rsi & mask), theseg);
+	dst_addr = get_addr_linear(core, (core->vm_regs.rsi & mask), theseg);
     
-	if (guest_va_to_host_va(info, dst_addr, &host_addr) == -1) {
-	    // either page fault or gpf...
+	if (v3_gva_to_hva(core, dst_addr, &host_addr) == -1) {
+	    PrintError(core->vm_info, core, "Could not translate outs dest addr, either page fault or gpf...\n");
+	    return -1;
 	}
 
-	if (hook->write(io_info->port, (char*)host_addr, write_size, hook->priv_data) != write_size) {
-	    // not sure how we handle errors.....
-	    PrintError("Write Failure for outs on port 0x%x\n", io_info->port);
-	    return -1;
+	if (hook == NULL) {
+	    PrintDebug(core->vm_info, core, "OUTS operation on unhooked IO port 0x%x - ignored\n", io_info->port);
+	} else {
+	    if (hook->write(core, io_info->port, (char*)host_addr, write_size, hook->priv_data) != write_size) {
+		// not sure how we handle errors.....
+		PrintError(core->vm_info, core, "Write Failure for outs on port 0x%x\n", io_info->port);
+		return -1;
+	    }
 	}
+	
 
-	info->vm_regs.rsi += write_size * direction;
+	core->vm_regs.rsi += write_size * direction;
 
 	if (io_info->rep) {
-	    info->vm_regs.rcx--;
+	    core->vm_regs.rcx--;
 	}
 
 	rep_num--;