X-Git-Url: http://v3vee.org/palacios/gitweb/gitweb.cgi?a=blobdiff_plain;f=palacios%2Fsrc%2Fpalacios%2Fmmu%2Fvmm_shdw_pg_swapbypass_32.h;h=3b745afceaca0c1a20040f099946e7d670ba42de;hb=9a32111c4074aafd55cd9590a24bd5c751a6fe61;hp=c0ce265d48d0eab86ea3c71fd89373da8039d7f5;hpb=e59d15ae2aab909879f817c3f45400d92af98a43;p=palacios.git diff --git a/palacios/src/palacios/mmu/vmm_shdw_pg_swapbypass_32.h b/palacios/src/palacios/mmu/vmm_shdw_pg_swapbypass_32.h index c0ce265..3b745af 100644 --- a/palacios/src/palacios/mmu/vmm_shdw_pg_swapbypass_32.h +++ b/palacios/src/palacios/mmu/vmm_shdw_pg_swapbypass_32.h @@ -68,7 +68,7 @@ static inline int handle_shadow_pagefault_32(struct guest_info * info, addr_t fa PrintDebug("Shadow page fault handler: %p\n", (void*) fault_addr ); PrintDebug("Handling PDE32 Fault\n"); - if (guest_pa_to_host_va(info, guest_cr3, (addr_t*)&guest_pd) == -1) { + if (v3_gpa_to_hva(info, guest_cr3, (addr_t*)&guest_pd) == -1) { PrintError("Invalid Guest PDE Address: 0x%p\n", (void *)guest_cr3); return -1; } @@ -174,7 +174,7 @@ static inline int handle_shadow_pagefault_32(struct guest_info * info, addr_t fa if (guest_pde->large_page == 0) { - if (guest_pa_to_host_va(info, BASE_TO_PAGE_ADDR(guest_pde->pt_base_addr), (addr_t*)&guest_pt) == -1) { + if (v3_gpa_to_hva(info, BASE_TO_PAGE_ADDR(guest_pde->pt_base_addr), (addr_t*)&guest_pt) == -1) { // Machine check the guest PrintDebug("Invalid Guest PTE Address: 0x%p\n", (void *)BASE_TO_PAGE_ADDR(guest_pde->pt_base_addr)); v3_raise_exception(info, MC_EXCEPTION); @@ -205,7 +205,7 @@ static int handle_pte_shadow_pagefault_32(struct guest_info * info, addr_t fault pte32_t * shadow_pte = (pte32_t *)&(shadow_pt[PTE32_INDEX(fault_addr)]); addr_t guest_pa = BASE_TO_PAGE_ADDR((addr_t)(guest_pte->page_base_addr)) + PAGE_OFFSET(fault_addr); - struct v3_shadow_region * shdw_reg = v3_get_shadow_region(info->vm_info, info->cpu_id, guest_pa); + struct v3_mem_region * shdw_reg = v3_get_mem_region(info->vm_info, info->vcpu_id, guest_pa); if (shdw_reg == NULL) { // Inject a machine check in the guest @@ -241,7 +241,7 @@ static int handle_pte_shadow_pagefault_32(struct guest_info * info, addr_t fault -#ifdef CONFIG_SYMBIOTIC_SWAP_TELEMETRY +#ifdef V3_CONFIG_SYMBIOTIC_SWAP_TELEMETRY if (error_code.write == 0) { info->vm_info->swap_state.read_faults++; } else { @@ -301,7 +301,7 @@ static int handle_pte_shadow_pagefault_32(struct guest_info * info, addr_t fault shadow_pte->page_base_addr = swp_pg_pa; -#ifdef CONFIG_SYMBIOTIC_SWAP_TELEMETRY +#ifdef V3_CONFIG_SYMBIOTIC_SWAP_TELEMETRY info->vm_info->swap_state.mapped_pages++; #endif // PrintError("Swap fault handled\n"); @@ -340,7 +340,12 @@ static int handle_pte_shadow_pagefault_32(struct guest_info * info, addr_t fault if ((shdw_reg->flags.alloced == 1) || (shdw_reg->flags.read == 1)) { - addr_t shadow_pa = v3_get_shadow_addr(shdw_reg, info->cpu_id, guest_pa); + addr_t shadow_pa = 0; + + if (v3_gpa_to_hpa(info, guest_pa, &shadow_pa) == -1) { + PrintError("could not translate page fault address (%p)\n", (void *)guest_pa); + return -1; + } shadow_pte->page_base_addr = PAGE_BASE_ADDR(shadow_pa); @@ -367,16 +372,14 @@ static int handle_pte_shadow_pagefault_32(struct guest_info * info, addr_t fault } - - // Write hooks trump all, and are set Read Only if (shdw_reg->flags.write == 0) { shadow_pte->writable = 0; } - } else if (shdw_reg->flags.hook == 1) { + } else { // Page fault handled by hook functions - if (v3_handle_mem_hook(info, fault_addr, guest_pa, shdw_reg, error_code) == -1) { + if (shdw_reg->unhandled(info, fault_addr, guest_pa, shdw_reg, error_code) == -1) { PrintError("Special Page fault handler returned error for address: %p\n", (void *)fault_addr); return -1; } @@ -384,15 +387,16 @@ static int handle_pte_shadow_pagefault_32(struct guest_info * info, addr_t fault } else if (shadow_pte_access == PT_ACCESS_WRITE_ERROR) { guest_pte->dirty = 1; - if (shdw_reg->flags.hook == 1) { - if (v3_handle_mem_hook(info, fault_addr, guest_pa, shdw_reg, error_code) == -1) { + + if (shdw_reg->flags.write == 1) { + PrintDebug("Shadow PTE Write Error\n"); + shadow_pte->writable = guest_pte->writable; + } else { + if (shdw_reg->unhandled(info, fault_addr, guest_pa, shdw_reg, error_code) == -1) { PrintError("Special Page fault handler returned error for address: %p\n", (void *)fault_addr); return -1; } - } else { - PrintDebug("Shadow PTE Write Error\n"); - shadow_pte->writable = guest_pte->writable; - } + } return 0; @@ -426,7 +430,7 @@ static int handle_4MB_shadow_pagefault_32(struct guest_info * info, PrintDebug("Handling 4MB fault (guest_fault_pa=%p) (error_code=%x)\n", (void *)guest_fault_pa, *(uint_t*)&error_code); PrintDebug("ShadowPT=%p, LargeGuestPDE=%p\n", shadow_pt, large_guest_pde); - struct v3_shadow_region * shdw_reg = v3_get_shadow_region(info->vm_info, info->cpu_id, guest_fault_pa); + struct v3_mem_region * shdw_reg = v3_get_mem_region(info->vm_info, info->vcpu_id, guest_fault_pa); if (shdw_reg == NULL) { @@ -449,8 +453,12 @@ static int handle_4MB_shadow_pagefault_32(struct guest_info * info, if ((shdw_reg->flags.alloced == 1) || (shdw_reg->flags.read == 1)) { - addr_t shadow_pa = v3_get_shadow_addr(shdw_reg, info->cpu_id, guest_fault_pa); + addr_t shadow_pa = 0; + if (v3_gpa_to_hpa(info, guest_fault_pa, &shadow_pa) == -1) { + PrintError("could not translate page fault address (%p)\n", (void *)guest_fault_pa); + return -1; + } shadow_pte->page_base_addr = PAGE_BASE_ADDR(shadow_pa); PrintDebug("\tMapping shadow page (%p)\n", (void *)BASE_TO_PAGE_ADDR(shadow_pte->page_base_addr)); @@ -476,21 +484,17 @@ static int handle_4MB_shadow_pagefault_32(struct guest_info * info, shadow_pte->global_page = large_guest_pde->global_page; // - } else if (shdw_reg->flags.hook == 1) { - if (v3_handle_mem_hook(info, fault_addr, guest_fault_pa, shdw_reg, error_code) == -1) { + } else { + if (shdw_reg->unhandled(info, fault_addr, guest_fault_pa, shdw_reg, error_code) == -1) { PrintError("Special Page Fault handler returned error for address: %p\n", (void *)fault_addr); return -1; } } } else if (shadow_pte_access == PT_ACCESS_WRITE_ERROR) { - - if (shdw_reg->flags.hook == 1) { - if (v3_handle_mem_hook(info, fault_addr, guest_fault_pa, shdw_reg, error_code) == -1) { - PrintError("Special Page Fault handler returned error for address: %p\n", (void *)fault_addr); - return -1; - } - } - + if (shdw_reg->unhandled(info, fault_addr, guest_fault_pa, shdw_reg, error_code) == -1) { + PrintError("Special Page Fault handler returned error for address: %p\n", (void *)fault_addr); + return -1; + } } else { PrintError("Error in large page fault handler...\n"); PrintError("This case should have been handled at the top level handler\n"); @@ -521,7 +525,7 @@ static inline int handle_shadow_invlpg_32(struct guest_info * info, addr_t vaddr pde32_t * guest_pd = NULL; pde32_t * guest_pde; - if (guest_pa_to_host_va(info, guest_cr3, (addr_t*)&guest_pd) == -1) { + if (v3_gpa_to_hva(info, guest_cr3, (addr_t*)&guest_pd) == -1) { PrintError("Invalid Guest PDE Address: 0x%p\n", (void *)guest_cr3); return -1; }