X-Git-Url: http://v3vee.org/palacios/gitweb/gitweb.cgi?a=blobdiff_plain;f=palacios%2Fsrc%2Fdevices%2Fi440fx.c;h=9b52eeda52a0d6c0fd2f76a39e051292fce3b981;hb=bc5ee3e07affac4810227d61c407011c05298518;hp=ee4dc8072fb3bab315637556eb53341fc4bcb6c8;hpb=123a1ba27ea09c8fa77a1b36ce625b43d7c48b14;p=palacios.git

diff --git a/palacios/src/devices/i440fx.c b/palacios/src/devices/i440fx.c
index ee4dc80..9b52eed 100644
--- a/palacios/src/devices/i440fx.c
+++ b/palacios/src/devices/i440fx.c
@@ -21,6 +21,8 @@
 #include <palacios/vmm_dev_mgr.h>
 #include <devices/pci.h>
 
+#include <palacios/vmm_io.h>
+
 
 // We Have to setup some sort of PIC interrupt mapping here....
 
@@ -29,12 +31,14 @@ struct i440_state {
 };
 
 
-static int io_read(ushort_t port, void * dst, uint_t length, struct vm_device * dev) {
+static int io_read(struct guest_info * core, ushort_t port, void * dst, uint_t length, void * priv_data) {
+    //    struct vm_device * dev = priv_data;
     PrintError("Unhandled read on port %x\n", port);
     return -1;
 }
 
-static int io_write(ushort_t port, void * src, uint_t length, struct vm_device * dev) {
+static int io_write(struct guest_info * core, ushort_t port, void * src, uint_t length, void * priv_data) {
+    //    struct vm_device * dev = priv_data;
     PrintError("Unhandled write on port %x\n", port);
     return -1;
 }
@@ -44,6 +48,18 @@ static int io_write(ushort_t port, void * src, uint_t length, struct vm_device *
 
 
 static int i440_free(struct vm_device * dev) {
+    struct i440_state * state = dev->private_data;
+    int i;
+
+    for (i = 0; i < 4; i++) {
+	v3_unhook_io_port(dev->vm, 0x0cf8 + i);
+	v3_unhook_io_port(dev->vm, 0x0cfc + i);
+    }
+
+    // unregister from PCI
+
+    V3_Free(state);
+
     return 0;
 }
 
@@ -57,13 +73,13 @@ static struct v3_device_ops dev_ops = {
 
 
 
-static int i440_init(struct guest_info * vm, v3_cfg_tree_t * cfg) {
+static int i440_init(struct v3_vm_info * vm, v3_cfg_tree_t * cfg) {
     struct pci_device * pci_dev = NULL;
     struct v3_pci_bar bars[6];
     int i;
     struct i440_state * state = NULL;
     struct vm_device * pci = v3_find_dev(vm, v3_cfg_val(cfg, "bus"));
-    char * name = v3_cfg_val(cfg, "name");
+    char * dev_id = v3_cfg_val(cfg, "ID");
 
     if (!pci) {
 	PrintError("could not find PCI Device\n");
@@ -74,19 +90,17 @@ static int i440_init(struct guest_info * vm, v3_cfg_tree_t * cfg) {
 
     state->pci = pci;
 	
-    struct vm_device * dev = v3_allocate_device(name, &dev_ops, state);
+    struct vm_device * dev = v3_allocate_device(dev_id, &dev_ops, state);
 
     if (v3_attach_device(vm, dev) == -1) {
-	PrintError("Could not attach device %s\n", name);
+	PrintError("Could not attach device %s\n", dev_id);
+	V3_Free(state);
 	return -1;
     }
 
-
     for (i = 0; i < 4; i++) {
-	v3_dev_hook_io(dev, 0x0cf8 + i,
-		       &io_read, &io_write);
-	v3_dev_hook_io(dev, 0x0cfc + i,
-		       &io_read, &io_write);
+	v3_hook_io_port(vm, 0x0cf8 + i, &io_read, &io_write, dev);
+	v3_hook_io_port(vm, 0x0cfc + i, &io_read, &io_write, dev);
     }
 
     for (i = 0; i < 6; i++) {
@@ -98,6 +112,7 @@ static int i440_init(struct guest_info * vm, v3_cfg_tree_t * cfg) {
 				     NULL, NULL, NULL, dev);
 
     if (!pci_dev) {
+	v3_detach_device(dev);
  	return -1;
     }
 
@@ -112,4 +127,4 @@ static int i440_init(struct guest_info * vm, v3_cfg_tree_t * cfg) {
     return 0;
 }
 
-device_register("i440FX", i440_init)
+device_register("i440FX", i440_init);