X-Git-Url: http://v3vee.org/palacios/gitweb/gitweb.cgi?a=blobdiff_plain;f=linux_module%2Fmain.c;h=f69b2691fb1b9b6155cfd1ed12a1cba52b445b7b;hb=a5d2c00cc461b4a60a1360a2a0bba55cef467bab;hp=310c5a11d3027df36853594d360ae9098c76f021;hpb=d775bbfa668ce9968bacc0e4257cf86e5ab88e90;p=palacios.git

diff --git a/linux_module/main.c b/linux_module/main.c
index 310c5a1..f69b269 100644
--- a/linux_module/main.c
+++ b/linux_module/main.c
@@ -122,6 +122,7 @@ static long v3_dev_ioctl(struct file * filp,
 	    guest->img_size = user_image.size;
 
 	    DEBUG("Palacios: Allocating kernel memory for guest image (%llu bytes)\n", user_image.size);
+	    // overflow possible here, but only if guest image is probably to large for kernel anyway...
 	    guest->img = palacios_valloc(guest->img_size);
 
 	    if (!guest->img) {
@@ -409,7 +410,7 @@ static int read_guests_details(struct seq_file *s, void *v)
     
     
  out:
-    if (mem) { palacios_vfree(mem); }
+    if (mem) { palacios_vfree(mem); } // dead code but kept for clarity
     if (core) { palacios_vfree(core); }
     if (base) { palacios_vfree(base); }