#include <palacios/vmm_instr_decoder.h>
-/* Disgusting mask hack...
- I can't think right now, so we'll do it this way...
-*/
-static const ullong_t mask_1 = 0x00000000000000ffLL;
-static const ullong_t mask_2 = 0x000000000000ffffLL;
-static const ullong_t mask_4 = 0x00000000ffffffffLL;
-static const ullong_t mask_8 = 0xffffffffffffffffLL;
-
-
-#define MASK(val, length) ({ \
- ullong_t mask = 0x0LL; \
- switch (length) { \
- case 1: \
- mask = mask_1; \
- break; \
- case 2: \
- mask = mask_2; \
- break; \
- case 4: \
- mask = mask_4; \
- break; \
- case 8: \
- mask = mask_8; \
- break; \
- } \
- val & mask; \
- })
+#define MASK(val, length) ({ \
+ ullong_t mask = 0x0LL; \
+ switch (length) { \
+ case 1: \
+ mask = 0x00000000000000ffLL; \
+ break; \
+ case 2: \
+ mask = 0x000000000000ffffLL; \
+ break; \
+ case 4: \
+ mask = 0x00000000ffffffffLL; \
+ break; \
+ case 8: \
+ mask = 0xffffffffffffffffLL; \
+ break; \
+ } \
+ val & mask; \
+ })
static v3_op_type_t op_form_to_type(op_form_t form);
static int parse_operands(struct guest_info * core, uint8_t * instr_ptr, struct x86_instr * instr, op_form_t form);
length = v3_get_prefixes((uint8_t *)instr_ptr, &(instr->prefixes));
- // check for REX prefix
+ // REX prefix
+ if (v3_get_vm_cpu_mode(core) == LONG) {
+ uint8_t prefix = *(uint8_t *)(instr_ptr + length);
+
+ if ((prefix & 0xf0) == 0x40) {
+ instr->prefixes.rex = 1;
+
+ instr->prefixes.rex_rm = (prefix & 0x01);
+ instr->prefixes.rex_sib_idx = ((prefix & 0x02) >> 1);
+ instr->prefixes.rex_reg = ((prefix & 0x04) >> 2);
+ instr->prefixes.rex_op_size = ((prefix & 0x08) >> 3);
+
+ length += 1;
+ }
+ }
form = op_code_to_form((uint8_t *)(instr_ptr + length), &length);
struct x86_instr * instr, op_form_t form) {
// get operational mode of the guest for operand width
uint8_t operand_width = get_operand_width(core, instr, form);
- uint8_t addr_width = get_addr_width(core, instr, form);
+ uint8_t addr_width = get_addr_width(core, instr);
int ret = 0;
uint8_t * instr_start = instr_ptr;
case MOV_IMM2:{
uint8_t reg_code = 0;
- instr->dst_operand.size = operand_width;
-
- ret = decode_rm_operand(core, instr_ptr, instr, &(instr->dst_operand), ®_code);
+ ret = decode_rm_operand(core, instr_ptr, form, instr, &(instr->dst_operand), ®_code);
if (ret == -1) {
PrintError("Error decoding operand\n");
instr->src_operand.type = IMM_OPERAND;
instr->src_operand.size = operand_width;
+
if (operand_width == 1) {
instr->src_operand.operand = *(uint8_t *)instr_ptr;
} else if (operand_width == 2) {
return -1;
}
+ instr->src_operand.read = 1;
+ instr->dst_operand.write = 1;
+
instr_ptr += operand_width;
instr->num_operands = 2;
case MOV_2MEM: {
uint8_t reg_code = 0;
- instr->dst_operand.size = operand_width;
-
- ret = decode_rm_operand(core, instr_ptr, instr, &(instr->dst_operand), ®_code);
+ ret = decode_rm_operand(core, instr_ptr, form, instr, &(instr->dst_operand), ®_code);
if (ret == -1) {
PrintError("Error decoding operand\n");
instr->src_operand.type = REG_OPERAND;
instr->src_operand.size = operand_width;
+ instr->src_operand.read = 1;
+ instr->dst_operand.write = 1;
+
+
decode_gpr(core, reg_code, &(instr->src_operand));
instr->num_operands = 2;
case XOR_MEM2:
case MOV_MEM2: {
uint8_t reg_code = 0;
- instr->src_operand.size = operand_width;
- ret = decode_rm_operand(core, instr_ptr, instr, &(instr->src_operand), ®_code);
+ ret = decode_rm_operand(core, instr_ptr, form, instr, &(instr->src_operand), ®_code);
if (ret == -1) {
PrintError("Error decoding operand\n");
instr->dst_operand.type = REG_OPERAND;
decode_gpr(core, reg_code, &(instr->dst_operand));
+ instr->src_operand.read = 1;
+ instr->dst_operand.write = 1;
+
instr->num_operands = 2;
break;
case SUB_IMM2SX_8:
case XOR_IMM2SX_8: {
uint8_t reg_code = 0;
- instr->src_operand.size = operand_width;
- ret = decode_rm_operand(core, instr_ptr, instr, &(instr->src_operand), ®_code);
+ ret = decode_rm_operand(core, instr_ptr, form, instr, &(instr->dst_operand), ®_code);
+
if (ret == -1) {
PrintError("Error decoding operand\n");
instr->src_operand.size = operand_width;
instr->src_operand.operand = *(sint8_t *)instr_ptr; // sign extend.
+ instr->src_operand.read = 1;
+ instr->dst_operand.write = 1;
+
instr_ptr += 1;
instr->num_operands = 2;
instr->src_operand.size = operand_width;
instr->src_operand.operand = get_addr_linear(core, MASK(core->vm_regs.rsi, addr_width), &(core->segments.ds));
+
instr->dst_operand.type = MEM_OPERAND;
instr->dst_operand.size = operand_width;
instr->dst_operand.operand = get_addr_linear(core, MASK(core->vm_regs.rdi, addr_width), &(core->segments.es));
+
+ instr->src_operand.read = 1;
+ instr->dst_operand.write = 1;
+
instr->num_operands = 2;
break;
case MOV_2CR: {
uint8_t reg_code = 0;
- instr->src_operand.size = operand_width;
-
- ret = decode_rm_operand(core, instr_ptr, instr, &(instr->src_operand),
+ ret = decode_rm_operand(core, instr_ptr, form, instr, &(instr->src_operand),
®_code);
if (ret == -1) {
instr->dst_operand.size = operand_width;
decode_cr(core, reg_code, &(instr->dst_operand));
+ instr->src_operand.read = 1;
+ instr->dst_operand.write = 1;
+
instr->num_operands = 2;
break;
}
case MOV_CR2: {
uint8_t reg_code = 0;
- instr->dst_operand.size = operand_width;
-
- ret = decode_rm_operand(core, instr_ptr, instr, &(instr->dst_operand),
+ ret = decode_rm_operand(core, instr_ptr, form, instr, &(instr->dst_operand),
®_code);
+
if (ret == -1) {
PrintError("Error decoding operand for (%s)\n", op_form_to_str(form));
return -1;
instr->src_operand.size = operand_width;
decode_cr(core, reg_code, &(instr->src_operand));
+ instr->src_operand.read = 1;
+ instr->dst_operand.write = 1;
+
instr->num_operands = 2;
break;
}
instr->dst_operand.size = operand_width;
instr->dst_operand.operand = get_addr_linear(core, MASK(core->vm_regs.rdi, addr_width), &(core->segments.es));
+ instr->src_operand.read = 1;
+ instr->dst_operand.write = 1;
+
instr->num_operands = 2;
break;
case INVLPG: {
uint8_t reg_code = 0;
- // We use the dst operand here to maintain bug-for-bug compatibility with XED
-
- instr->dst_operand.size = operand_width;
-
- ret = decode_rm_operand(core, instr_ptr, instr, &(instr->dst_operand), ®_code);
+ ret = decode_rm_operand(core, instr_ptr, form, instr, &(instr->dst_operand), ®_code);
if (ret == -1) {
PrintError("Error decoding operand for (%s)\n", op_form_to_str(form));